942909 - Add in the gaia test cleanUp() a option to setup prefs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

This would help us setup prefs at test run time 

One of these would help us debug apps with app manager more easily

Comment 1

[Florin Strugariu [:Bebe]]

we would read the prefs from testvars file and set the in the cleanup method as we setup settings

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14205

Pointer to Github pull-request

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8340242 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14205

r+ with the addition of documentation, unless this is intentionally undocumented (I don't know your particular use case)

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8340242 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14205

r+, but I'd love to see a test for it.

Comment 5

[Bob Silverberg [:bsilverberg]]

We should bring this into v1.2 too, after it lands on master.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8340242 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14205

Just one nit, but otherwise looks good to me. r=me with the unit test class name changed. Note that I haven't run the tests. The Travis-CI failures are unrelated.

Comment 7

[Florin Strugariu [:Bebe]]

Dave  done

Comment 8

[Zac C (:zac)]

Comment on attachment 8340242 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14205

r+

Comment 9

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/8e432d26abdd2b6cfeb256042ede3c962d516750