Closed
Bug 942997
Opened 12 years ago
Closed 12 years ago
[Clock] Update to Dark 1.3 Header
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files)
Update to the dark header in the New and Edit alarm screens of the clock app. The screen is currently light, but is becoming dark in bug 919530 - that's why I've requested the dark header in case there's any confusion :). I've attached an image of the dark UI that is currently being implemented. Thanks!
Reporter | ||
Updated•12 years ago
|
Assigning to Pavel since he is already working on alarm app.
Pavel, I noticed that the alarm is not using shared styles. It would be good to include the use of the headers here.
Assignee: kyee → pivanov
Reporter | ||
Comment 2•12 years ago
|
||
Ok, thanks Casey. Hey Pavel, let me know if you need me to mock this up. But the edit and new alarm screens should use the dark header we are using in music, gallery, etc. Thanks!
Flags: needinfo?(pivanov)
Assignee | ||
Comment 3•12 years ago
|
||
Hey Gays,
I think that it will be good idea if we open a new bug to implement the new header in the app
Flags: needinfo?(pivanov)
Reporter | ||
Comment 4•12 years ago
|
||
Hey Pavel, this is a new bug that's just for the header :)
Reporter | ||
Updated•12 years ago
|
Flags: needinfo?(pivanov)
Assignee | ||
Comment 5•12 years ago
|
||
oh ... sorry my bad
We need to land Bug 919530 first.
P.S. I already have a patch for this one :)
Depends on: 919530
Flags: needinfo?(pivanov)
Assignee | ||
Comment 6•12 years ago
|
||
It's just adding a class name
Attachment #8340534 -
Flags: review?(pivanov)
Assignee | ||
Updated•12 years ago
|
Attachment #8340534 -
Flags: review?(pivanov) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/0746788d9f472832377180c625b14cc7e3a75652
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•