94301 - [xlib] Xlib-port uses other fonts than GTK+-port

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Roland Mainz]

Xlib gfx code (gfx/src/xlib/) is more or less a port of GTK+ gfx code
(gfx/src/gtk/) from GTK+/GDK library to plain libX11 calls...

... in theory both gfx modules should use exactly the same fonts - but they are
currently (=2001-08-05-08-trunk) using different fonts... for example - most
fonts are slightly bigger...

... any ideas ?

Comment 1

[Tomi Leppikangas]

I left fonts big bigger on purpose so i can see am i using gtk or xlib :)

I think this will fix that:
gfx/src/xlib/nsDeviceContextXlib.cpp
- #define XLIB_DEFAULT_FONT1 "-*-helvetica-medium-r-*-*-*-140-*-*-*-*-iso8859-1"
+ #define XLIB_DEFAULT_FONT1 "-*-helvetica-medium-r-*-*-*-120-*-*-*-*-iso8859-1"

Comment 2

[Roland Mainz]

Attachment: (Partial !?) patch for 2001-08-05-08-trunk

Comment 3

[Roland Mainz]

Filed patch.
But I still see differences in fonts... more ideas ?

Comment 4

[Tomi Leppikangas]

My patch works for me, your patch misses one '*'

Comment 5

[Roland Mainz]

I copied the strings from GTK+ toolkit after I tested your versions. There is
still a difference in both versions vs. GTK+ build.

Interesting detail: Xprint module (which uses nsFontMetricsXlib.cpp) behaves
differently on Xlib and GTK+ builds. Why ? 
In theory both should create identical results... or not ?

Mhhh... sometimes |gFontSubConverter->Init()| fails in
nsFontXlibSubstitute::Convert()... is that related to this issue ?

Comment 6

[Roland Mainz]

Any news here ?

Stealing bug from pocemit to get it on my "0.9.4 radar" ...

Comment 7

[Roland Mainz]

Requestiong r=/sr= for the patch ...

Comment 8

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron on attachment 45069 [details] [diff] [review]

Comment 10

[Roland Mainz]

Requesting sr= ...

Comment 11

[tor]

sr=tor on attachment 45069 [details] [diff] [review]

Comment 12

[Roland Mainz]

Requesting a= for {0.9.4,trunk} - this two line patch is too simple to not make
it in 0.9.4 ... :-))

Comment 13

[Asa Dotzler [:asa]]

a=asa on behalf of drivers.

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

C:\moz_src\mozilla\gfx\src\xlib>cvs commit -m "Bug 94301. X-lib-port uses other
fonts than GTK+-port. Patch by [e-mail] (gisbu
rn on irc) r=dbaron sr=tor a=asa on behalf of drivers" nsDeviceContextXlib.cpp
Checking in nsDeviceContextXlib.cpp;
/cvsroot/mozilla/gfx/src/xlib/nsDeviceContextXlib.cpp,v  <--  nsDeviceContextXli
b.cpp
new revision: 1.42; previous revision: 1.41
done