Keep Scrolling Portion of Gallery App as One Layer using will-animate

RESOLVED FIXED

Status

Firefox OS
Gaia::Gallery
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c=handeye p=2 s= u=])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
append will-animate css property to scrollable portions of the gallery app.
(Assignee)

Comment 1

4 years ago
Created attachment 8341179 [details] [diff] [review]
gallery.patch

Patch keeps the scrolling portion of the gallery app in one layer. Currently targeting both the thumbnail view and swiping between pictures after touching one image. Video of patch in action:
https://www.dropbox.com/s/tfnm37ss1wr9hlk/gallery.mov

One potential optimization might be to keep the back button and bottom toolbar from being repainted on each swipe left/right.
Attachment #8341179 - Flags: review?(bgirard)
(In reply to Mason Chang [:mchang] from comment #1)
> One potential optimization might be to keep the back button and bottom
> toolbar from being repainted on each swipe left/right.

I think we should be able to avoid invalidating those without using will-animate. If this is a performance priority we should investigate why.

Updated

4 years ago
Attachment #8341179 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

4 years ago
Landed.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

4 years ago
https://github.com/mozilla-b2g/gaia/pull/14283

Updated

4 years ago
Depends on: 961871
You need to log in before you can comment on or make changes to this bug.