Closed Bug 943089 Opened 9 years ago Closed 9 years ago

Keep Scrolling Portion of Gallery App as One Layer using will-animate

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Gallery
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [c=handeye p=2 s= u=])

Attachments

(1 file)

gallery.patch
1.03 KB, patch
BenWa
: review+
Details | Diff | Splinter Review 
append will-animate css property to scrollable portions of the gallery app.
Attached patch gallery.patch — — Splinter Review 
Patch keeps the scrolling portion of the gallery app in one layer. Currently targeting both the thumbnail view and swiping between pictures after touching one image. Video of patch in action:
https://www.dropbox.com/s/tfnm37ss1wr9hlk/gallery.mov

One potential optimization might be to keep the back button and bottom toolbar from being repainted on each swipe left/right.
Attachment #8341179 - Flags: review?(bgirard)
(In reply to Mason Chang [:mchang] from comment #1)
> One potential optimization might be to keep the back button and bottom
> toolbar from being repainted on each swipe left/right.

I think we should be able to avoid invalidating those without using will-animate. If this is a performance priority we should investigate why.
Attachment #8341179 - Flags: review?(bgirard) → review+
Landed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: will-change
You need to log in before you can comment on or make changes to this bug.