943123 - [B2G][E-Mail] "Select Folder" screen when moving emails to different folders has UI issue with partial circles on button corners

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
In E-Mail application when moving selected emails to a different folder, the "Select Folder" screen has a UI issue showing blue partial circles on the upper left corner of each folder select button.

Repro Steps:
1) Updated Buri to Build ID: 20131125142741
2) With email account set up open E-Mail app
3) Press edit button in inbox
4) Select one or more emails
5) Choose move to folder button

Actual:
Select Folder screen shows blue partial circles on corners of folder selection buttons.

Expected:
Select Folder screen UI displays buttons as expected.

Environmental Variables
Device: Buri v 1.3 Mozilla RIL
Build ID: 20131125142741
Gecko: http://hg.mozilla.org/mozilla-central/rev/757c2011df5b
Gaia: bd8053d30c275f8d3040cd494e04b3480a784656
Platform Version: 28.0a1
Firmware Version: V1.2_US_20131115

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Jason Smith [:jsmith]]

Ugly VD regression, probably from the recent value selector work.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Note that e-mail has an old somewhat hacked up copy of value selector logic from somewhere and its own CSS, but building blocks could easily be interfering with it.

See:
https://github.com/mozilla-b2g/gaia/blob/master/apps/email/js/value_selector.js
https://github.com/mozilla-b2g/gaia/blob/master/apps/email/style/value_selector.css

Comment 3

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri 1.3 Mozilla RIL
BuildID: 20131113040200
Gaia: 7243b75041c93bc7deb240131748d0b164f3f0b0
Gecko: 7b014f0f3b03
Version: 28.0a1
Base Image: V1.2_20131115

First Broken Environmental Variables:
Device: Buri 1.3 Mozilla RIL
BuildID: 20131114143149
Gaia: 4ea5adac92d6a9ab035e708e941d50be0d670da2
Gecko: 7b014f0f3b03
Version: 28.0a1
Base Image: V1.2_20131115

Comment 4

[Jason Smith [:jsmith]]

yet another regression from bug 914892

Comment 5

[Jason Smith [:jsmith]]

eeejay - Can you look into this?

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14357

Pointer to Github pull-request

Comment 7

[Jason Smith [:jsmith]]

(In reply to Eitan Isaacson [:eeejay] from comment #6)
> Created attachment 8342299 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gaia/pull/14357
> 
> Pointer to Github pull-request

Note - you probably want asuth to review that, as he's the person who owns the email codebase.

Comment 8

[Eitan Isaacson [:eeejay]]

Comment on attachment 8342299 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14357

Thanks!

Comment 9

[James Burke [:jrburke]]

Comment on attachment 8342299 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14357

Stealing the review from :asuth -- checked on device, and this change fixes the issue, r+ from me.

Comment 10

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/2d48cb9f06115c38d7241f5615e35efd9a96f9b2