943176 - Use Full Line Highlights in Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fabien Cazenave [:kaze]]

This had been fixed by bug 917704 but it’s been broken again with the new “flat design” stylesheets.

Comment 1

[Fabien Cazenave [:kaze]]

Attachment: screenshot — before patch

Comment 2

[Fabien Cazenave [:kaze]]

This might be a regression caused by bug 914892. Eitan, can you confirm?
If that’s a regression, please steal this bug and put me in review. Thanks!

Comment 3

[Fabien Cazenave [:kaze]]

FTR, this bug only affects on/off switches, check boxes and radio buttons. Other list items are fine.

Comment 4

[Fabien Cazenave [:kaze]]

I confirm this is caused by bug 914892. Eitan, can you look at it please?

Comment 5

[Eitan Isaacson [:eeejay]]

Indeed. I could pot a fix up here.

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14093

Pointer to Github pull-request

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8338928 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14093

This is not a holistic solution since that would require changing the box model for *everything*. But it does the trick. I noticed that the highlight on the bluetooth enable switch is bad, but that is not my doing. I'll file a bug though :)

Comment 8

[Fabien Cazenave [:kaze]]

Comment on attachment 8338928 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14093

Wow, nice trick! I feel so stupid for having spent 2+ hours trying to fix that with negative margins.

Comment 9

[Fabien Cazenave [:kaze]]

(In reply to Eitan Isaacson [:eeejay] from comment #7)
> I noticed that the highlight
> on the bluetooth enable switch is bad, but that is not my doing. I'll file a
> bug though :)

Yes please! :-)
I noticed the “Do Not Track” radio buttons look bad too, I’ll file a bug.

Thanks again for your responsiveness.

Comment 10

[Fabien Cazenave [:kaze]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/edaf61cdf8b7efa7b458a557f175c717d1cfcddb