B2G RIL: [DSDS] Follow-up of bug 814637 - enable new marionette tests of IccManager

RESOLVED FIXED in 1.3 Sprint 6 - 12/6

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

unspecified
1.3 Sprint 6 - 12/6
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a follow-up of Bug #814637 +++

In bug 814637, we have added two new test cases for new IccManager's API.
- test_icc_access_invalid_object.js
- test_icc_detected_undetected_event.js

But they were disabled temporarily due to bug 933654 (Please see bug 814637 comment #74).

We should enable it back after bug 933654 is fixed.
(Assignee)

Comment 1

5 years ago
Created attachment 8338387 [details] [diff] [review]
Patch, v1
(Assignee)

Comment 2

5 years ago
Comment on attachment 8338387 [details] [diff] [review]
Patch, v1

1). Enable below test cases,
    - test_icc_access_invalid_object.js
    - test_icc_detected_undetected_event.js
2). Use the MobileConnection API to enable/disable radio.
3). Try result is good: https://tbpl.mozilla.org/?tree=Try&rev=9ef6137cf2fc
Attachment #8338387 - Flags: review?(htsai)
Comment on attachment 8338387 [details] [diff] [review]
Patch, v1

Review of attachment 8338387 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8338387 - Flags: review?(htsai) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 8341067 [details] [diff] [review]
Patch, v2, r=hsinyi

Rebase only.
Attachment #8338387 - Attachment is obsolete: true
Attachment #8341067 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/755b42fa10eb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in before you can comment on or make changes to this bug.