Add-ons overlaying toolbar buttons directly onto the addon-bar lose their positions because they get evicted every time

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 2 bugs, {addon-compat})

unspecified
Firefox 28
addon-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P2])

Attachments

(1 attachment)

(In reply to :Gijs Kruitbosch from bug 854226 comment #22)
> (In reply to klonos from bug 854226 comment #21)
> > I'm seeing various similar issues with addon buttons returning to the same
> > position after browser restart no matter where they were moved (such an
> > example addon is Wappalyzer)
> 
> I had a look, and Wappalyzer directly overlays the add-on bar. I didn't
> think of this case when I wrote the shim that manages stuff that gets added
> to the add-on bar, so it's probably not handled in the best way. I'll
> investigate this further in a separate bug.
Created attachment 8338454 [details] [diff] [review]
fix add-on-bar-bound positioning due to Australis shim,

Here's another thing we should fix about this shim. Simple patch, fortunately. Tested, and works with wappalyzer (you need to toggle the pref to have it show things in its addonbar icon rather than the urlbar icon though).
Attachment #8338454 - Flags: review?(mconley)
Comment on attachment 8338454 [details] [diff] [review]
fix add-on-bar-bound positioning due to Australis shim,

LGTM! Thanks Gijs.
Attachment #8338454 - Flags: review?(mconley) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/e1214a4d199b
Status: NEW → ASSIGNED
Whiteboard: [Australis:P2] → [Australis:P2][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e1214a4d199b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][fixed-in-fx-team] → [Australis:P2]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.