943326 - run-if = os == 'b2g' does not work in b2g-desktop

Status: RESOLVED INVALID

(Testing :: General, defect, P2)

Description

[Fernando Jiménez Moreno [:ferjm]]

|run-if = os == 'b2g'| does not work in b2g-desktop as the OS_TARGET value is the one corresponding to the host machine. It would be great if we could add a mention to that in the docs [1]. The alternative in this case is to use |run-if = appname == 'b2g'|

[1] https://ci.mozilla.org/job/mozilla-central-docs/Build_Documentation/mozinfo.html#mozinfo-attributes

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

ahal, can we just document what is needed here and move on?

I clicked on the link above and it resulted in a 404.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: include b2g desktop in os == b2g

I think the expected behaviour here would be for b2g desktop to be included in os == b2g. I believe the only reason it is the way it is now was because b2g desktop didn't exist (or wasn't used in automation) back when this code was written. I'd like ted's opinion though.

I think the only thing that could be affected by this change would be vaibhav's work on b2g desktop mochitest manifests, and it looks like he doesn't use 'os' at all. Joel, do you have any reasons not to do this?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I would be fine doing this.  We could adjust the patch as it hasn't landed yet (waiting on a skip-if for directories right now)

Comment 4

[Andrew Halberstadt [:ahal]]

I don't think the patch would need to adjusted.. it would just be a cosmetic change (using 'os' instead of 'buildapp')

Comment 5

[(not currently active) Ted Mielczarek]

I'm really not sure here. I guess you can still differentiate via toolkit, which makes this not terrible either way, but B2G is sort of a weird case, in that it's an OS but also we have desktop builds. I guess if people's expectations are that "os == 'b2g'" matches B2G on any platform, then that's what we ought to do.

Comment 6

[Andrew Halberstadt [:ahal]]

I guess it boils down to this: when using skip-if = os == 'linux', do you also mean to disable the test in b2g desktop? I can see cases where people might inadvertently disable tests on b2g desktop. That being said, I can also see people inadvertently disabling b2g desktop tests when using os == 'b2g' too. I think the takeaway here is that 'os' might not be a very good filter to use when disabling tests.

Maybe instead of lumping it under b2g, we should create a new 'b2gdt' os?

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 8385340 [details] [diff] [review]
include b2g desktop in os == b2g

Review of attachment 8385340 [details] [diff] [review]:
-----------------------------------------------------------------

This is kind of terrible any way we slice it, so whatever you think is best.

Comment 8

[Andrew Halberstadt [:ahal]]

I'm honestly not sure if taking this is a good idea or not. On one hand os == 'Android' for b2g is unintuitive, on the other, people are used to that since that is how it works in the build system. I'm unassigning myself for now..

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

B2G is gone.