943353 - Don't include X11 headers if MOZ_X11 is undefined

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[dmitry.rojkov]

Attachment: disable-x11-bits.patch

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131115110311

Steps to reproduce:

Try to build web engine with the configure option --without-x and with no X11 headers installed.


Actual results:

gecko doesn't build


Expected results:

gecko should build successfully

Comment 1

[dmitry.rojkov]

Seems to be fixed in 29.0a1

Comment 2

[Oleg Romashin (:romaxa)]

No it is not fixed in 29... patch is still needed

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Ifdef X11 API usage under MOZ_X11

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8363382 [details] [diff] [review]
Ifdef X11 API usage under MOZ_X11

Review of attachment 8363382 [details] [diff] [review]:
-----------------------------------------------------------------

These are upstream files from webrtc.org; almost all patches to those files should at least be possible uplift candidates.

This means that it should not use MOZ_* defines; it should use a gyp variable (which exists: use_x11) to enable compiler defines for the audio code (a conditional 'defines' section).

Then the use_x11 default (1 on non-win/mac/android/ios) should be overridden in build/gyp.mozbuild if X11 is not supported in our build.

Once we have a known-good patch, we should open an Issue at webrtc.org, and upload a patch made against the trunk of the webrtc.org codebase to their codereview site.  (And link to the Issue in our bug.)

Thanks!

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Ifdef X11 API usage under USE_X11

Ok sounds like we have already USE_X11 defined and it is not enabled in my non-x11 environment.
http://mxr.mozilla.org/mozilla-central/search?string=USE_X11&find=webrtc&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8363697 [details] [diff] [review]
Ifdef X11 API usage under USE_X11

Review of attachment 8363697 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  Please mark as checkin-needed (in Keywords); if it won't let you comment here.  And please open an Issue at webrtc.org, and if you can download the trunk of their codebase and upload a patch to their codereview.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8363697 [details] [diff] [review]
Ifdef X11 API usage under USE_X11

Please use only checkin-needed.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/532334f94108

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/532334f94108