943383 - 'Allow now' becomes 'allow and remember' if looking again in the CTP doorhanger

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Open http://benjamin.smedbergs.us/tests/ctptests/javaflash-together.html
2. 'Allow Now' Flash
3. Open the CTP doorhanger

AR: Flash is 'Allow and remember'

Comment 1

[Paul Silaghi, QA [:pauly]]

'Allow now' Flash:
after bug 926605 landed, Flash is 'Block plugin'
after bug 932786 landed, Flash is 'Allow and remember'

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

How is this verified as fixed on 26 in https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c13 but now no longer working as expected?  Did something else change between landing bug 932786 and now?  Benjamin or David - is this a major issue or is it like in https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c2 where it only affects a small subsection of users?

Comment 3

[Paul Silaghi, QA [:pauly]]

(In reply to [e-mail] [:lsblakk] from comment #2)
> How is this verified as fixed on 26 in
> https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c13 but now no longer
> working as expected? 
This is a different issue, even if the titles look closer.

Comment 4

[(Away)]

(In reply to [e-mail] [:lsblakk] from comment #2)
> How is this verified as fixed on 26 in
> https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c13 but now no longer
> working as expected?  Did something else change between landing bug 932786
> and now?  Benjamin or David - is this a major issue or is it like in
> https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c2 where it only affects
> a small subsection of users?

I don't have any experience with CtP. John, is this something you can answer?

Comment 5

[John Schoenick [:johns]]

The multi-item popup is a different case than the single-item popup that is bugged. If it's not difficult, it would be a good idea to add this to the ctp browserchrome tests, however.

Seeing as it is a broken confusing UI, and probably not too complicated to fix, I'm guessing we should track

Comment 6

[Benjamin Smedberg]

This is a very minor piece of UI, and not something that I would track at all. It still shows the correct enabled state, it just doesn't show you whether it's "for now" or "always" correctly.

Comment 7

[Georg Fritzsche [:gfritzsche]]

The permission that is stored is indeed correct - this is just the display in the doorhanger being incorrect until you reload/reopen the page.
Will probably finish up later this week.

Comment 8

[Georg Fritzsche [:gfritzsche]]

Attachment: Fix state not being remembered.

https://tbpl.mozilla.org/?tree=Try&rev=2220d0f76274

Comment 9

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d784aa614a9

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3d784aa614a9

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed 29.0a1 (2013-12-11) Win 7 x64