943395 - [Messages][Drafts] Replace existing Draft layer needed when replacing draft

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Evelyn Eastmond [:evhan55]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=879143#c84

Comment 1

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/rwaldron/gaia/pull/8

- `thread_ui.js`
    - Check if existing draft when about to save a draft, is so, ask about 'replacing' the existing draft

- `thread_ui_test.js`
    - Check that the correct `OptionMenu` is presented when replacing an existing draft

Comment 2

[Evelyn Eastmond [:evhan55]]

This PR is now on top of rwaldron/v1.3-drafts + rwaldron/947211 by accident.  But I think I should probably leave all my bugs that way, or no?  I can keep rebasing all my current work on top of both of them and cancel this PR against v1.3-drafts for now?

Comment 3

[Evelyn Eastmond [:evhan55]]

Cancelling this PR until 211 lands

Comment 4

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/rwaldron/gaia/pull/11

Reverified that this bug exists on the most recent rwaldron/v1.3-drafts.
Reran all tests, etc.
Filing a new PR:

- `thread_ui.js`
    - Check if existing draft when about to save a draft, is so, ask about 'replacing' the existing draft

- `thread_ui_test.js`
    - Check that the correct `OptionMenu` is presented when replacing an existing draft

Comment 5

[Rick Waldron [:rwaldron]]

Landed on v1.3-drafts https://github.com/rwaldron/gaia/commit/c651bcd99b72d374f1b023adbb789469e2c323ea

Comment 6

[Julien Wajsberg [:julienw]]

master: cdb45404e6556c7e86869e461f79f981cd783ab0

Comment 7

[Rick Waldron [:rwaldron]]

Whoops, I missed this one—thanks Julien!