Closed Bug 943425 Opened 6 years ago Closed 6 years ago

Avoid creating empty MoveGroups

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: sunfish, Assigned: sunfish)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

There are a few places where the register allocators call getEntryMoveGroup or getExitMoveGroup before checking whether it's actually needed. This results in an empty MoveGroup. Attached is a patch which adds helper functions for inserting moves at block entry and exit which avoid creating empty MoveGroups.
Attachment #8338562 - Flags: review?(bhackett1024)
Attachment #8338562 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/9866d2a831a2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.