Closed
Bug 943442
Opened 11 years ago
Closed 11 years ago
Tidy MDefinition::id()
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: sunfish, Assigned: sunfish)
Details
Attachments
(2 files)
|
2.08 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
|
828 bytes,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Reading the code in MIRGraph::allocDefinitionId I was curious whether incrementing the counter by 2 was significant. It seems not to be the case. Attached is a patch which changes to increment by 1, so that it looks less interesting, and potentially to make it useful for indexing into side tables.
Attachment #8338594 -
Flags: review?(dvander)
|
Assignee | |
Comment 1•11 years ago
|
||
And a related follow-up patch, MDefinitions can be compared by pointer, since two MDefinitions never share the same id() value.
Attachment #8338597 -
Flags: review?(dvander)
|
|
||
Updated•11 years ago
|
Attachment #8338594 -
Flags: review?(dvander) → review+
|
|
||
Updated•11 years ago
|
Attachment #8338597 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b2fc22adeb24
https://hg.mozilla.org/mozilla-central/rev/15768548e7e3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•