Closed Bug 943442 Opened 8 years ago Closed 8 years ago

Tidy MDefinition::id()

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: sunfish, Assigned: sunfish)

Details

Attachments

(2 files)

Attached patch vn-ssa-id.patchSplinter Review
Reading the code in MIRGraph::allocDefinitionId I was curious whether incrementing the counter by 2 was significant. It seems not to be the case. Attached is a patch which changes to increment by 1, so that it looks less interesting, and potentially to make it useful for indexing into side tables.
Attachment #8338594 - Flags: review?(dvander)
And a related follow-up patch, MDefinitions can be compared by pointer, since two MDefinitions never share the same id() value.
Attachment #8338597 - Flags: review?(dvander)
Attachment #8338594 - Flags: review?(dvander) → review+
Attachment #8338597 - Flags: review?(dvander) → review+
You need to log in before you can comment on or make changes to this bug.