Closed
Bug 943508
Opened 11 years ago
Closed 11 years ago
slaveapi should verify that the shell is available before running commands over ssh
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
|
2.15 KB,
patch
|
jhopkins
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
It looks like it's taking longer to start the shell on Windows machines than it used to. (My testing by hand has it taking 20-30s, sometimes longer). I don't know why this is, but slaveapi should be able to cope with this better. The current code makes a bad assumption that 5s ought to be enough for any slave. If it takes longer than that, the command won't run. We should do some more robust checking for a functional shell - maybe we can echo some string and look for it in the output or something...
|
Assignee | |
Updated•11 years ago
|
Summary: slaveapi can't run commands on windows slaves anymore → slaveapi should verify that the shell is available before running commands over ssh
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8339459 [details] [diff] [review] detect shell readyness Would prefer a check of the timeout against the actual elapsed time, but this should be fine.
Attachment #8339459 -
Flags: review?(jhopkins) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8339459 [details] [diff] [review] detect shell readyness Landed this with a version bump. Planning to deploy it tomorrow.
Attachment #8339459 -
Flags: checked-in+
|
|
Assignee | |
Comment 4•11 years ago
|
||
This is landed in dev+prod, and I verified that it's working.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•