Closed Bug 943557 Opened 11 years ago Closed 9 years ago

Use modifier keys for click events generated by single-tap gestures in Android APZC code

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mbrubeck, Unassigned)

References

Details

Bug 942689 added keyboard modifier info to the "tap" gestures sent by AsyncPanZoomController.  To take advantage of this on Android when using APZC, we'll need to take the modifier info passed to AndroidBridge::HandleSingleTap and pass it as part of the Gesture:SingleTap notification here:
http://hg.mozilla.org/mozilla-central/file/34f431863037/widget/android/AndroidBridge.cpp#l1990

...and then use that info in the code here that receives the Gesture:SingleTap message, and add it to the simulated mouse events:
http://hg.mozilla.org/mozilla-central/file/34f431863037/mobile/android/chrome/content/browser.js#l4380
With the latest advances in APZ technology, we shouldn't need to use Gesture:SingleTap any more once we do the switch. Instead we use the ChromeProcessController::HandleSingleTap which does its own dispatching of simulated mouse events, complete with modifier info.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.