Closed Bug 943614 Opened 7 years ago Closed 7 years ago

Calling GetDataSurface() should always return a surface with surface->GetType() == SURFACE_DATA

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [qa-])

Attachments

(3 files)

This will make it easier to reject non-DataSourceSurfaces in DrawSurface when mixing DrawTargets and SourceSurfaces of different backends.
Attachment #8338834 - Flags: review?(bas)
Comment on attachment 8338834 [details] [diff] [review]
part 1: Add DataSourceSurfaceWrapper and use it in the implementation of DataSourceSurface::GetDataSurface

Review of attachment 8338834 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DataSourceSurface.cpp
@@ +17,5 @@
> +    temp = this;
> +  } else {
> +    temp = new DataSourceSurfaceWrapper(this);
> +  }
> +  return temp.forget();

Don't need the .forget();
Attachment #8338834 - Flags: review?(bas) → review+
The other backends don't seem to need any fixing.
Attachment #8338838 - Flags: review?(bas) → review+
Attachment #8338840 - Flags: review?(bas) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.