94363 - Search UI: Sorting results should scroll to show selection

Status: RESOLVED DUPLICATE of bug 186999

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using aug06 commerical trunk build

If you switch the sort in the search messages results pane when the list is long
enough to warrant a scrollbar, upon resort the pane doesn't always scroll to
show the selected message.

1.  Edit|Search Mail/News Messages.  Initiate a search on a folder/group which
will yield many results, requiring a scrollbar.
2.  Sort the results pane by Sender. 
3.  Go to the the end of the list and select a message near the bottom of the list.
4.  Click the Sender column again to resort in opposite descending/ascending order.

Result: list resorts, but your selection point is now out of the current view.

Expected:  list resorts and scrolls to show your selection.

Comment 1

[(not reading, please use [e-mail] instead)]

I did something similar to this for the thread pane.

Comment 2

[(not reading, please use [e-mail] instead)]

easy to do, but this is UI polish.  moving out.

Comment 3

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 4

[laurel]

problem still exists dec14 commercial trunk build, all platforms

Comment 5

[Peter Trudelle]

nsbeta1- per ADT triage, ->1.2, blocks 'miracle bug' 122274

Comment 6

[laurel]

nominating for next release

Comment 7

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 8

[(not reading, please use [e-mail] instead)]

re-assign to shuehan.

Comment 9

[shliang]

Attachment: patch

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 123026 [details] [diff] [review]
patch

makes me nervous that we are fixing a search issue in the base class.

msgdbview is fragile, my guess is this would cause some regressions.

what about fixing this in nsMsgSearchDBView.cpp?

double check that nsMsgSearchDBView is only used by the advanced search dialog?

Comment 11

[(not reading, please use [e-mail] instead)]

more questions:

1) make sure to test what happens if the selected message from before the search
isn't in the new search results

2) in this case, who is callin RestoreSelection()?

Comment 12

[(not reading, please use [e-mail] instead)]

shuehan tells me that she sees this same bug in this scenario:

1) use the 3 pane
2) but collapse the message pane (so we are suppressing the message display)

so that means there is something wrong with the base class.

I'm still not 100% sure there is no regression lurking here.

we'll continue to discuss.

Comment 13

[Mike Cowperthwaite]

The problem with the thread-pane of the 3-pane display also scrolling the 
selection out of view is bug 186999.  The message-body pane does not need to be 
collapsed to make this happen.

Comment 14

[John Oppenheimer]

What is the status of this issue?

The ability to keep selected message within the window has been a feature in
Netscape for years.

I find Mozilla mail to be rather unusable for large folders when trying to
change the sort column because I can not find the selected message again without
much effort!

Comment 15

[Mike Cowperthwaite]

Bug 186999 has been fixed as of today's nightly build, and it appears this bug 
has been fixed because of it.  Neil, can you confirm that this should be the 
case?

Comment 16

[[e-mail]]

Yes, this appears to be a special case of bug 186999, so marking as dupe.

*** This bug has been marked as a duplicate of 186999 ***