Closed Bug 943672 Opened 10 years ago Closed 10 years ago

Convert to Promise.jsm in Scratchpad

Categories

(DevTools Graveyard :: Scratchpad, defect, P2)

Product:
DevTools Graveyard
Component:
Scratchpad
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: bbenvie, Assigned: bbenvie)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

promise-scratchpad.patch
3.72 KB, patch
anton
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch promise-scratchpad.patch (obsolete) — — Splinter Review 
Switches Scratchpad to use Promise.jsm. https://tbpl.mozilla.org/?tree=Try&rev=e1b7bf5968ff
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Fixes the failure. https://tbpl.mozilla.org/?tree=Try&rev=490e98d01269
Attachment #8338923 - Attachment is obsolete: true
Attachment #8339449 - Flags: review?(anton)
Comment on attachment 8339449 [details] [diff] [review]
promise-scratchpad.patch

Review of attachment 8339449 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/scratchpad/scratchpad-panel.js
@@ +14,5 @@
>    let { Scratchpad } = iframeWindow;
>    this._toolbox = toolbox;
>    this.panelWin = iframeWindow;
>    this.scratchpad = Scratchpad;
>    

Trailing whitespace.
Attachment #8339449 - Flags: review?(anton) → review+
https://hg.mozilla.org/mozilla-central/rev/c76bbc91063e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Whiteboard: [qa-]
Blocks: 996671
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.