Closed
Bug 943672
Opened 11 years ago
Closed 11 years ago
Convert to Promise.jsm in Scratchpad
Categories
(DevTools Graveyard :: Scratchpad, defect, P2)
DevTools Graveyard
Scratchpad
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: bbenvie, Assigned: bbenvie)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
3.72 KB,
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Switches Scratchpad to use Promise.jsm. https://tbpl.mozilla.org/?tree=Try&rev=e1b7bf5968ff
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
Fixes the failure. https://tbpl.mozilla.org/?tree=Try&rev=490e98d01269
Attachment #8338923 -
Attachment is obsolete: true
Attachment #8339449 -
Flags: review?(anton)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8339449 [details] [diff] [review]
promise-scratchpad.patch
Review of attachment 8339449 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/scratchpad/scratchpad-panel.js
@@ +14,5 @@
> let { Scratchpad } = iframeWindow;
> this._toolbox = toolbox;
> this.panelWin = iframeWindow;
> this.scratchpad = Scratchpad;
>
Trailing whitespace.
Attachment #8339449 -
Flags: review?(anton) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•