943685 - Convert to Promise.jsm in the app manager

Status: RESOLVED INVALID

(DevTools Graveyard :: WebIDE, defect, P2)

Comment 1

[Brandon Benvie [:benvie]]

Attachment: promise-appmanager.patch

Switches app manger to use Promise.jsm. https://tbpl.mozilla.org/?tree=Try&rev=e72f99504fff

Comment 2

[Brandon Benvie [:benvie]]

Attachment: promise-appmanager.patch

I have a feeling this won't fix the failure, but let's try. https://tbpl.mozilla.org/?tree=Try&rev=3a6725252b5e

Comment 3

[Brandon Benvie [:benvie]]

Clarification: this is a timing issue I cannot reproduce locally. =(

Comment 4

[:Paolo Amadini]

Still failing:

https://tbpl.mozilla.org/?tree=Try&rev=fa3da02191dd

Comment 5

[:Paolo Amadini]

Attachment: Updated patch

Still failing after this obvious fix.

https://tbpl.mozilla.org/?tree=Try&rev=a2a32ac71943

Comment 6

[:Paolo Amadini]

Attachment: Race condition

There seems to be a race condition with the selectProject function. It seems that the first project added is selected automatically, but we click the first element in the list again during the selection process, and this triggers the race condition.

This added timeout makes the race condition occur locally.

This might be related to the intermittent failure in bug 950613.

Ideas on how to fix this?

Comment 7

[:Paolo Amadini]

Attachment: Simplified test

Simplified the test, but still fails remotely and not when run individually.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

App Manager is slated to be removed, so it may not make sense to work on this.

Comment 9

[Alexandre Poirot [:ochameau]]

App manager removed!