943716 - [Flatfish][Contact] tap on a contact's phone number pops up a warning of no network connection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: NoNetworkConnection.png

Gaia:     7aabb9fc5f7034fac8f25ed72220f6533d171420  │  
Gecko:    3dcb11b3de948b95a1d2321a52ff84dd1970b15c  │  
BuildID   20131127064521                            │  
Version   28.0a1                                    │  
ro.build.version.incremental=20131127   

1. Open "Contact".
2. Add a contact with phone number, then save.
3. Tap the contact to see its detail.
4. Tap on phone number.
5. "No network connection" shown. ( See NoNetworkConnection.png)

Comment 1

[Eric Chang [:ericcc] [:echang]]

No sure what's the best way to handle this.
1. Make the phone number field not able to be tapped? 
2. Let other app handle this, if there is an app who can handle calls installed on device?

Comment 2

[Eric Chang [:ericcc] [:echang]]

1. Open "Contact".
2. Add a contact with phone number, then save.
3. Tap the contact to see its detail.
4. Tap on phone number << added >> OR tap on SMS icon(takes couple minutes to activate)
5. "No network connection" shown. ( See NoNetworkConnection.png)

Comment 3

[Francis Lee [:frlee]]

hi Joe,

are you able to help me to redirect this bug to comms team member?

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

this requires UX
and given where flatfish is, this should not block.

Comment 5

[Francis Lee [:frlee]]

hi Mike,

as flatfish doesn't support telephony, could you please comment or define UX behavior for it?

Comment 6

[GoodMike]

Yes, Francis. From UX's perspective, I think there shouldn't be any pop-up window for tapping phone number.
The action should be disabled. Just show plain phone number, not tappable. Thanks.

Comment 7

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

My first idea was to launch a dial web activity when mozTelephony is unavailable, keeping the option for an hypothetical voip app to fulfill it.

But we can't currently install the contacts app without the dialer app, so the dialer was still being launched.

So in this patch, we do nothing when telephony isn't available.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8344657 [details] [review]
Gaia PR

Simple and effective solution.

Please merge once travis is green.

Thanks Etienne!

Comment 9

[Etienne Segonzac (:etienne)]

Ah! A marionette test is rightfully failing, I'll wip up a new patch.

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8344657 [details] [review]
Gaia PR

updated the PR with an updated test.
can you take a quick look?

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8344657 [details] [review]
Gaia PR

r+ wiht minor comments on github.

Rerunning the travis job to get the precious green.

Thanks again Etienne!

Comment 12

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/5705238b2a9864771fb15073552a4e4ca8f4631d

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 5705238b2a9864771fb15073552a4e4ca8f4631d to:
v1.3: 432266ef37e54ff8866ed8cd686df5afb1f884cc