Closed Bug 943716 Opened 6 years ago Closed 6 years ago

[Flatfish][Contact] tap on a contact's phone number pops up a warning of no network connection

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

RESOLVED FIXED
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: echang, Assigned: etienne)

Details

(Whiteboard: [Flatfish only][developer+])

Attachments

(2 files)

Attached image NoNetworkConnection.png
Gaia:     7aabb9fc5f7034fac8f25ed72220f6533d171420  │  
Gecko:    3dcb11b3de948b95a1d2321a52ff84dd1970b15c  │  
BuildID   20131127064521                            │  
Version   28.0a1                                    │  
ro.build.version.incremental=20131127   

1. Open "Contact".
2. Add a contact with phone number, then save.
3. Tap the contact to see its detail.
4. Tap on phone number.
5. "No network connection" shown. ( See NoNetworkConnection.png)
No sure what's the best way to handle this.
1. Make the phone number field not able to be tapped? 
2. Let other app handle this, if there is an app who can handle calls installed on device?
blocking-b2g: --- → 1.3?
Flags: needinfo?(frlee)
1. Open "Contact".
2. Add a contact with phone number, then save.
3. Tap the contact to see its detail.
4. Tap on phone number << added >> OR tap on SMS icon(takes couple minutes to activate)
5. "No network connection" shown. ( See NoNetworkConnection.png)
hi Joe,

are you able to help me to redirect this bug to comms team member?
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(frlee)
Flags: needinfo?(jcheng)
this requires UX
and given where flatfish is, this should not block.
blocking-b2g: 1.3+ → 1.3?
Flags: needinfo?(jcheng) → needinfo?(frlee)
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(frlee)
hi Mike,

as flatfish doesn't support telephony, could you please comment or define UX behavior for it?
Flags: needinfo?(mtsai)
Yes, Francis. From UX's perspective, I think there shouldn't be any pop-up window for tapping phone number.
The action should be disabled. Just show plain phone number, not tappable. Thanks.
Flags: needinfo?(mtsai)
Assignee: nobody → etienne
Attached file Gaia PR
My first idea was to launch a dial web activity when mozTelephony is unavailable, keeping the option for an hypothetical voip app to fulfill it.

But we can't currently install the contacts app without the dialer app, so the dialer was still being launched.

So in this patch, we do nothing when telephony isn't available.
Attachment #8344657 - Flags: review?(francisco.jordano)
Comment on attachment 8344657 [details] [review]
Gaia PR

Simple and effective solution.

Please merge once travis is green.

Thanks Etienne!
Attachment #8344657 - Flags: review?(francisco.jordano) → review+
Ah! A marionette test is rightfully failing, I'll wip up a new patch.
Comment on attachment 8344657 [details] [review]
Gaia PR

updated the PR with an updated test.
can you take a quick look?
Attachment #8344657 - Flags: review+ → review?(francisco.jordano)
Comment on attachment 8344657 [details] [review]
Gaia PR

r+ wiht minor comments on github.

Rerunning the travis job to get the precious green.

Thanks again Etienne!
Attachment #8344657 - Flags: review?(francisco.jordano) → review+
https://github.com/mozilla-b2g/gaia/commit/5705238b2a9864771fb15073552a4e4ca8f4631d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Uplifted 5705238b2a9864771fb15073552a4e4ca8f4631d to:
v1.3: 432266ef37e54ff8866ed8cd686df5afb1f884cc
You need to log in before you can comment on or make changes to this bug.