943717 - [Window Management] Move appWindow creation from AppWindowManager to AppWindowFactory

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Now AppWindow is instanced in (App-)WindowManager instead of AppWindowFactory.
Since we're having three window manager now it's strange that AWM does the instanciation but other don't.

Original design is because the old WindowManager has some dirty code to render browser frame.
Since we're rendering it all by BrowserFrame class now, let's do the instanciation in AppWindowFactory and file a openapp request to AppWindowManager once launchapp event its config is not "stayBackground".

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14566

Clean AppWindow/ActivityWindow instantiation process.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Travis: it seems the red is causing by others.
https://travis-ci.org/mozilla-b2g/gaia/builds/15277578

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8345814 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14566

r=me with the tests and documentation comments addressed.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

https://travis-ci.org/mozilla-b2g/gaia/builds/15380139

Cardview test seems fail for recent pull requests but the test work on local device so I'm merging.

 ~/Projects/gaia ⮀ ⭠ bugzilla/943717/app-window-factory-creation  ⮀ gaiatest --testvars=../testvars.json --restart tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view/test_cards_view_kill_apps_with_two_apps.py --address=localhost:2828 --type=b2g
starting httpd
running webserver on http://10.247.30.174:60224/
test_kill_app_from_cards_view (test_cards_view_kill_apps_with_two_apps.TestCardsViewTwoApps) ... /Library/Python/2.6/site-packages/mozdevice-0.29-py2.6.egg/mozdevice/devicemanagerADB.py:269: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if foundpath == filepath:
ok

----------------------------------------------------------------------
Ran 1 test in 55.158s

OK

SUMMARY
-------
passed: 1
failed: 0
todo: 0

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/f37d213166634107cc9beb2d2648dfeb9b8ae26a
Thanks for careful review!