Closed
Bug 943722
Opened 12 years ago
Closed 12 years ago
Remove unused #sound-selection item in Settings
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kaze, Assigned: kaze)
References
Details
Attachments
(1 file)
Follow-up of bug 905856: when the sound selection panel has been replaced by a web activity, we forgot to get rid of the related <section> in the main HTML file.
That’s the last item that raises an import warning, let’s fix this.
| Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → kaze
Attachment #8339011 -
Flags: review?(arthur.chen)
Comment 2•12 years ago
|
||
Comment on attachment 8339011 [details] [review]
patch
We should also remove "audioPreview" function in utils.js. r=me.
Attachment #8339011 -
Flags: review?(arthur.chen) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Thanks for the good catch. Merged on master:
https://github.com/mozilla-b2g/gaia/commit/d977692c333d365c7cf07d0fb3cda3375ef7e2b3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•