Closed Bug 943735 Opened 8 years ago Closed 8 years ago

Defect - Typing backspace in the urlbar should de-select the selected autocomplete tile

Categories

(Firefox for Metro Graveyard :: App Bar, defect, P2)

All
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 28

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Whiteboard: [block28] feature=defect c=tbd u=tbd p=1)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Steps to reproduce:
1. Begin typing in the urlbar
2. Press tab or down to select an autocomplete tile
3. Press backspace
4. Press enter

Expected results: The autocomplete tile is de-selected after step 3.  After step 4, the address in the urlbar loads.

Actual results: The autocomplete tile is still selected after step 3.  After step 4, the address of the selected tile loads.

This happens because our autocomplete popup has broken selectedIndex and selectedItem setters.
Attachment #8339050 - Flags: review?(msamuel)
Flags: in-testsuite?
Blocks: metrov1it20
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: p=1 → [block28] feature=defect c=tbd u=tbd p=1
Attached patch patch v2Splinter Review
Now with an automated test!
Attachment #8339050 - Attachment is obsolete: true
Attachment #8339050 - Flags: review?(msamuel)
Attachment #8339054 - Flags: review?(msamuel)
Comment on attachment 8339054 [details] [diff] [review]
patch v2

Review of attachment 8339054 [details] [diff] [review]:
-----------------------------------------------------------------

I tried this out and it works well for autocomplete de-selecting, but it doesn't de-select the bing/google/yahoo tiles if you tab to those. Is this something we want to do as well?
Attachment #8339054 - Flags: review?(msamuel) → review+
(In reply to Marina Samuel [:emtwo] from comment #2)
> I tried this out and it works well for autocomplete de-selecting, but it
> doesn't de-select the bing/google/yahoo tiles if you tab to those. Is this
> something we want to do as well?

Ah, good catch.  I'm not sure what we should do for that case.  On the one hand having the same behavior would be good for consistency; on the other hand the interaction is different.  (The search section always updates to reflect what you are typing.)  I'm going to land this basic fix for now, and we can file a new bug if we find the search tiles are a problem.

https://hg.mozilla.org/integration/fx-team/rev/61dfe6cb955d
Summary: Defect - Typing in the urlbar should de-select the selected autocomplete tile → Defect - Typing backspace in the urlbar should de-select the selected autocomplete tile
https://hg.mozilla.org/mozilla-central/rev/61dfe6cb955d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Mozilla/5.0 (Windows NT 6.3; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified as fixed on latest Nightly (build ID: 20131215030202) using the the STR from comment 0 and comment 2 and got the expected results.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.