943763 - Esc only closes quick search when it has focus

Status: NEW

(Toolkit :: Find Toolbar, enhancement, P4)

Description

[Robin Nixon]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131112160018

Steps to reproduce:

After using Ctrl-F to search on a page you can press Esc to close the search.


Actual results:

If you click within the searched web page, however, the Esc key is no longer functional for closing the search box unless you click into the search box to give it focus. Only then will Esc close it.


Expected results:

The old method of closing search was to be able to press Esc at any time and remove the search bar from the bottom of the screen. I think this should be restored because now you need extra mouse clicks to be able to do this.

Comment 1

[Thomas D. (:thomas8)]

Nice one. Thunderbird has just implemented this behaviour for message composition in bug 530629, so the UX of this can be tested in DailyBird :)

However, it's much worse to get stuck in Firefox Full Screen Mode where ESC will not get you out (Bug 474070, much to everyone's surprise because it works in fullscreen of all other apps and plugins), and looking at Mozilla's lack of interest to implement ESC shortcut there since 2009, it would really come as a surprise if they'd bother to do so here. Just my 2 cents.

Comment 3

[andydecleyre]

I'm using 46.0.1 on Arch Linux, and neither the quick find bar nor the standard find bar close when hitting ESC, regardless of where focus is. It seems I would need to install an add-on simply to close the find bar with the keyboard. Should I file a separate bug, or does this problem belong right here?

Comment 4

[andydecleyre]

I decide my problem is probably different, so I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1276101 .