943809 - [bluedroid] HID prototype

Status: RESOLVED DUPLICATE of bug 1223729

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

[bluedroid] HID prototype

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug943809-Part1: Relocate files

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug943809-Part2: BluetoothHidManager for bluedroid

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8339889 [details] [diff] [review]
Bug943809-Part2: BluetoothHidManager for bluedroid

During integration with Setting, I found I missed event notification part.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part1: Relocate files

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part2: BluetoothHidManager for bluedroid

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part 3: Fired hid event when hid connection status changed

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: hid-gaia.patch

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part4: Add NotifyStatusChanged for BluetoothHidManager if using bluez as the backend

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8340944 [details] [diff] [review]
hid-gaia.patch

Shawn, thanks for the first gaia patch! :)

Please check my comment. And we also need to do some modifications on system/js/bluetooth.js.

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: hid-gaia-v2.patch

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part1: Reallocate Hid files

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part2: Hid prototype

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8340997 [details] [diff] [review]
hid-gaia-v2.patch

Review of attachment 8340997 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/system/js/bluetooth.js
@@ +10,4 @@
>        OPP: 'opp',   // Object Push Profile
>        A2DP: 'a2dp', // A2DP status
>        SCO: 'sco'    // Synchronous Connection-Oriented
> +      HID: 'hid'    // Synchronous Connection-Oriented

Please add the full name of "HID".

@@ +181,4 @@
>        self.updateConnected();
>      };
>  
> +    adapter.onhfpstatuschanged = function bt_hidStatusChanged(evt) {

Should be "onhidstatuschanged".

Comment 14

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: hid-gaia-v3.patch

Comment 15

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug943809 - Part 5: Clobber chages

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341525 [details] [diff] [review]
hid-gaia-v3.patch

Review of attachment 8341525 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thank you for the effort!

Comment 17

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8341005 [details] [diff] [review]
Bug 943809 - Part1: Reallocate Hid files

Review of attachment 8341005 [details] [diff] [review]:
-----------------------------------------------------------------

Please remember to touch CLOBBER in order to trigger a clean build on tinderbox.

Comment 18

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] (OOO 12/12 ~ 12/15) from comment #17)
> Comment on attachment 8341005 [details] [diff] [review]
> Bug 943809 - Part1: Reallocate Hid files
> 
> Review of attachment 8341005 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please remember to touch CLOBBER in order to trigger a clean build on
> tinderbox.

Oh, I saw the 5th patch. Please forget what I just said in comment 17. :)

Comment 19

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8341005 [details] [diff] [review]
Bug 943809 - Part1: Reallocate Hid files

We shall use 'hg mv' instead of deleting files.

Comment 20

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part1: Reallocate Hid files

Comment 21

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part2: Hid prototype

Comment 22

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 943809 - Part1: Reallocate Hid files

Comment 23

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I've tried this patch on Nexus-4 with Apple Wireless keyboard and Logitech keyboard, which is based on bluedroid stack.

Comment 24

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

If you have problem with reconnect, see also bug 953019. Some HID keyboards don't support connection initiated from phone.

Comment 25

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Pass HID feature to Jocelyn :)

Comment 26

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Move on :)

Comment 27

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

We're going to have major refactoring on Bluetooth module, especially removing BT HAL dependent data type. So, after that was done, we will work on rebase patches.

Comment 28

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Because we changed the way to access bluedroid through bluetoothd. These patch need to be re-written.

Comment 29

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hey cyu,
If you are interested in this bug, here you go!

Comment 30

[[e-mail]]

Since we moved to Bluetooth APIv2, The gaia patch need to be re-written as well

Comment 31

[Cervantes Yu [:cyu] [:cervantes]]

Remove NI flag since this is currently not on my plate.

Comment 33

[Louis Chang [:louis]]

Bug 1223729 has covered HID prototype.