943847 - Load button on correlations tab throws JS error

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Schalk Neethling [:espressive]]

When a user clicks on the 'Load' button on the correlations tab (report/list) and there is not data returned, it silently fails with an error in the console:

TypeError: data is null

Comment 1

[Schalk Neethling [:espressive]]

TEST CASE
---------

Navigate to report/list and click on the correlations tab.

Click on any of the two 'Load' buttons on this tab, the following should now happen:

1) On click the load button is replaced by a spinner with Loading text
2) If results are returned, it will replace the spinner with the content
3) If no data is found, the spinner will be replaced by a message stating: 'No correlation data found.'

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/71e45d06e231e037e63dfd08e8bfea7f5e5a1603
Fix Bug 943847, handle cases where data is null and add spinner on click

https://github.com/mozilla/socorro/commit/e99b7f975297046d08372bcd55f6972e679b552d
Merge pull request #1695 from ossreleasefeed/bug943847-load-button-on-correlations-tab-throws-js-error

Fix Bug 943847, handle cases where data is null and add spinner on click

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-12-04&signature=mozilla%3A%3Alayers%3A%3ADeviceManagerD3D9%3A%3AInit%28%29&version=Firefox%3A28.0a1

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Before-fix screenshot

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 6

[Lonnen :lonnen]

retargeting