Closed Bug 943865 Opened 6 years ago Closed 6 years ago

Increase timeout in wait_for_filmstrip_not_visible

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Other
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v1.2 affected)

RESOLVED FIXED
Tracking Status
b2g-v1.2 --- affected

People

(Reporter: zcampbell, Assigned: viorela)

Details

Attachments

(2 files)

In camera/app.py, the timeout for wait_for_filmstrip_not_visible is variable now depending upon the command line timeout.

however the behaviour is a set amount of time. We should hard-code this wait to 10 seconds to be sure that it waits at least the right amount of time for the filmstrip to close naturally.
Assignee: nobody → viorela.ioia
Attachment #8339302 - Flags: review?(zcampbell)
Attachment #8339302 - Flags: review?(andrei.hutusoru)
Comment on attachment 8339302 [details] [review]
PR: https://github.com/mozilla-b2g/gaia/pull/14129

r- small tweak in method def.
Attachment #8339302 - Flags: review?(zcampbell)
Attachment #8339302 - Flags: review?(andrei.hutusoru)
Attachment #8339302 - Flags: review-
Attachment #8339302 - Flags: review- → review?
Comment on attachment 8341717 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14314

Uplifted to v1.2
Attachment #8341717 - Flags: review?(florin.strugariu)
Attachment #8341717 - Flags: review?(bob.silverberg)
Comment on attachment 8341717 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14314

Please merge this when the tree reopens.
Attachment #8341717 - Flags: review?(bob.silverberg) → review+
Attachment #8341717 - Flags: review?(florin.strugariu) → review+
You need to log in before you can comment on or make changes to this bug.