Closed
Bug 943865
Opened 12 years ago
Closed 12 years ago
Increase timeout in wait_for_filmstrip_not_visible
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | affected |
People
(Reporter: zcampbell, Assigned: viorela)
Details
Attachments
(2 files)
In camera/app.py, the timeout for wait_for_filmstrip_not_visible is variable now depending upon the command line timeout.
however the behaviour is a set amount of time. We should hard-code this wait to 10 seconds to be sure that it waits at least the right amount of time for the filmstrip to close naturally.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → viorela.ioia
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8339302 -
Flags: review?(zcampbell)
Attachment #8339302 -
Flags: review?(andrei.hutusoru)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 8339302 [details] [review]
PR: https://github.com/mozilla-b2g/gaia/pull/14129
r- small tweak in method def.
Attachment #8339302 -
Flags: review?(zcampbell)
Attachment #8339302 -
Flags: review?(andrei.hutusoru)
Attachment #8339302 -
Flags: review-
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8339302 -
Flags: review- → review?
|
|
Reporter | |
Comment 3•12 years ago
|
||
status-b2g-v1.2:
--- → affected
|
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 8339302 [details] [review]
PR: https://github.com/mozilla-b2g/gaia/pull/14129
r+
Attachment #8339302 -
Flags: review? → review+
|
|
||
Comment 5•12 years ago
|
||
Pointer to Github pull-request
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 8341717 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14314
Uplifted to v1.2
Attachment #8341717 -
Flags: review?(florin.strugariu)
Attachment #8341717 -
Flags: review?(bob.silverberg)
|
||
Comment 7•12 years ago
|
||
Comment on attachment 8341717 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14314
Please merge this when the tree reopens.
Attachment #8341717 -
Flags: review?(bob.silverberg) → review+
|
||
Comment 8•12 years ago
|
||
Merged
V1.2 in
https://github.com/mozilla-b2g/gaia/commit/0310600f62fa0203d2ac1fb74c1a48b210d45e9f
master in
https://github.com/mozilla-b2g/gaia/commit/733e1e8795cb077bda4c961d23f653dc0dae0df9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Attachment #8341717 -
Flags: review?(florin.strugariu) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•