Closed Bug 943865 Opened 6 years ago Closed 6 years ago
Increase timeout in wait
_for _filmstrip _not _visible
46 bytes, text/x-github-pull-request
|Details | Review|
358 bytes, text/html
In camera/app.py, the timeout for wait_for_filmstrip_not_visible is variable now depending upon the command line timeout. however the behaviour is a set amount of time. We should hard-code this wait to 10 seconds to be sure that it waits at least the right amount of time for the filmstrip to close naturally.
Comment on attachment 8339302 [details] [review] PR: https://github.com/mozilla-b2g/gaia/pull/14129 r- small tweak in method def.
Attachment #8339302 - Flags: review- → review?
Comment on attachment 8339302 [details] [review] PR: https://github.com/mozilla-b2g/gaia/pull/14129 r+
Attachment #8339302 - Flags: review? → review+
Pointer to Github pull-request
Comment on attachment 8341717 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14314 Uplifted to v1.2
Comment on attachment 8341717 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14314 Please merge this when the tree reopens.
Attachment #8341717 - Flags: review?(bob.silverberg) → review+
Merged V1.2 in https://github.com/mozilla-b2g/gaia/commit/0310600f62fa0203d2ac1fb74c1a48b210d45e9f master in https://github.com/mozilla-b2g/gaia/commit/733e1e8795cb077bda4c961d23f653dc0dae0df9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8341717 - Flags: review?(florin.strugariu) → review+
You need to log in before you can comment on or make changes to this bug.