944074 - PJS: rm ParallelArray

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Shu-yu Guo [:shu]]

As agreed between myself, till, and nmatsakis, no point in keeping it around before TypedObject lands

Comment 1

[Shu-yu Guo [:shu]]

Anybody has any ideas on what should be done with the many fuzz tests that contain ParallelArray? Many of them don't really have anything to do with parallelism and are Ion bugs, since ParallelArray was a major (only?) vector that forced Ion regardless of shell flags.

Comment 2

[Jeff Walden [:Waldo]]

Fix 'em on a case-by-case basis to not use ParallelArray.  (This is why I never land a fuzz-test with a patch, and I always take the fuzz-test and extract a minimal testcase based on the exact issues discovered and include that instead.)

Comment 3

[Shu-yu Guo [:shu]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Fix 'em on a case-by-case basis to not use ParallelArray.  (This is why I
> never land a fuzz-test with a patch, and I always take the fuzz-test and
> extract a minimal testcase based on the exact issues discovered and include
> that instead.)

I'm going to try to replace the use of ParallelArray with Array's parallel method counterparts.

Some of the tests were automatically added (tests/auto-regress). I don't know how that happens.

Extracting a minimal testcase is easier said than done for many of the travesties generated by the fuzzer (many of which are "the perfect storm" kind of situations), though I will admit that I was lazy on some of the tests.

Comment 4

[Shu-yu Guo [:shu]]

Attachment: Remove the ParallelArray constructor.

Comment 5

[Shu-yu Guo [:shu]]

try here: https://tbpl.mozilla.org/?tree=Try&rev=1fe7fa8f878a

Comment 6

[Shu-yu Guo [:shu]]

Attachment: Followup: undefined min and max from <windows.h> to prevent conflicts.

Stupid stupid Windows.

Comment 7

[Shu-yu Guo [:shu]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b07452dd6d7f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/daa324f7e65a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b07452dd6d7f
https://hg.mozilla.org/mozilla-central/rev/daa324f7e65a

Comment 9

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ParallelArray
https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility