Closed Bug 944074 Opened 7 years ago Closed 7 years ago

PJS: rm ParallelArray

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: shu, Assigned: shu)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

As agreed between myself, till, and nmatsakis, no point in keeping it around before TypedObject lands
Anybody has any ideas on what should be done with the many fuzz tests that contain ParallelArray? Many of them don't really have anything to do with parallelism and are Ion bugs, since ParallelArray was a major (only?) vector that forced Ion regardless of shell flags.
Fix 'em on a case-by-case basis to not use ParallelArray.  (This is why I never land a fuzz-test with a patch, and I always take the fuzz-test and extract a minimal testcase based on the exact issues discovered and include that instead.)
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Fix 'em on a case-by-case basis to not use ParallelArray.  (This is why I
> never land a fuzz-test with a patch, and I always take the fuzz-test and
> extract a minimal testcase based on the exact issues discovered and include
> that instead.)

I'm going to try to replace the use of ParallelArray with Array's parallel method counterparts.

Some of the tests were automatically added (tests/auto-regress). I don't know how that happens.

Extracting a minimal testcase is easier said than done for many of the travesties generated by the fuzzer (many of which are "the perfect storm" kind of situations), though I will admit that I was lazy on some of the tests.
Attachment #8345605 - Flags: review?(nmatsakis)
Assignee: nobody → shu
Status: NEW → ASSIGNED
Stupid stupid Windows.
Attachment #8346358 - Flags: review?(jdemooij)
Attachment #8346358 - Flags: review?(jdemooij) → review+
Attachment #8345605 - Flags: review?(nmatsakis) → review+
https://hg.mozilla.org/mozilla-central/rev/b07452dd6d7f
https://hg.mozilla.org/mozilla-central/rev/daa324f7e65a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.