PJS: rm ParallelArray

RESOLVED FIXED in mozilla29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: shu, Assigned: shu)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla29
dev-doc-complete, site-compat
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
As agreed between myself, till, and nmatsakis, no point in keeping it around before TypedObject lands
(Assignee)

Comment 1

5 years ago
Anybody has any ideas on what should be done with the many fuzz tests that contain ParallelArray? Many of them don't really have anything to do with parallelism and are Ion bugs, since ParallelArray was a major (only?) vector that forced Ion regardless of shell flags.

Comment 2

5 years ago
Fix 'em on a case-by-case basis to not use ParallelArray.  (This is why I never land a fuzz-test with a patch, and I always take the fuzz-test and extract a minimal testcase based on the exact issues discovered and include that instead.)
(Assignee)

Comment 3

5 years ago
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Fix 'em on a case-by-case basis to not use ParallelArray.  (This is why I
> never land a fuzz-test with a patch, and I always take the fuzz-test and
> extract a minimal testcase based on the exact issues discovered and include
> that instead.)

I'm going to try to replace the use of ParallelArray with Array's parallel method counterparts.

Some of the tests were automatically added (tests/auto-regress). I don't know how that happens.

Extracting a minimal testcase is easier said than done for many of the travesties generated by the fuzzer (many of which are "the perfect storm" kind of situations), though I will admit that I was lazy on some of the tests.
(Assignee)

Comment 4

5 years ago
Created attachment 8345605 [details] [diff] [review]
Remove the ParallelArray constructor.
Attachment #8345605 - Flags: review?(nmatsakis)
(Assignee)

Updated

5 years ago
Assignee: nobody → shu
Status: NEW → ASSIGNED
(Assignee)

Comment 6

5 years ago
Created attachment 8346358 [details] [diff] [review]
Followup: undefined min and max from <windows.h> to prevent conflicts.

Stupid stupid Windows.
Attachment #8346358 - Flags: review?(jdemooij)

Updated

5 years ago
Attachment #8346358 - Flags: review?(jdemooij) → review+
Attachment #8345605 - Flags: review?(nmatsakis) → review+
https://hg.mozilla.org/mozilla-central/rev/b07452dd6d7f
https://hg.mozilla.org/mozilla-central/rev/daa324f7e65a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.