The default bug view has changed. See this FAQ.

/revisions/ page doesn't show who made the most recent change to a rule

RESOLVED FIXED

Status

Release Engineering
Balrog: Frontend
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: massimo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
(Might apply to releases too, I'm not sure if that code is generic.)

Eg: https://aus4-admin.mozilla.org/rules/18/revisions/ shows 5 versions of that rule. I happen to know that Nick made the most recent change, but it doesn't show up in the UI...

Updated

3 years ago
Duplicate of this bug: 944083
Bug 944083 also has suggestions for the ordering of the table, and how to display dates of changes.
(Assignee)

Updated

3 years ago
Assignee: nobody → mgervasini
(Reporter)

Comment 3

3 years ago
I don't think this truly blocks moving beta users to balrog, but it is fairly important.
No longer blocks: 933414
(Assignee)

Comment 4

3 years ago
Created attachment 8452589 [details] [diff] [review]
[balrog] Bug 944075.patch

Added {{ revision['changed_by'] }} in loop.last
Attachment #8452589 - Flags: review?(bhearsum)
(Assignee)

Updated

3 years ago
Attachment #8452589 - Flags: review?(bhearsum)
(Assignee)

Comment 5

3 years ago
Created attachment 8452672 [details] [diff] [review]
[balrog] Bug 944075.patch

Updated patch so the most recent release is at the top.
Attachment #8452589 - Attachment is obsolete: true
Attachment #8452672 - Flags: review?(nthomas)
Comment on attachment 8452672 [details] [diff] [review]
[balrog] Bug 944075.patch

lgtm
Attachment #8452672 - Flags: review?(nthomas) → review+

Comment 7

3 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/b9ccdd2a12974a7992f411214dfeed29fdcc78f2
Bug 944075 - /revisions/ page doesn't show who made the most recent change to a rule. r=nthomas
(Assignee)

Updated

3 years ago
Attachment #8452672 - Flags: checked-in+
(Assignee)

Comment 8

3 years ago
Created attachment 8452801 [details] [diff] [review]
[balrog] Bug 944075 - remove attribute parameter from sort().patch

Removed attribute='change_id' from sort(). 'attribute' was added in jinja2 and we are using jinjia2 2.5.5
Attachment #8452801 - Flags: review?(nthomas)

Updated

3 years ago
Attachment #8452801 - Flags: review?(nthomas) → review+

Comment 9

3 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/ee9d67842d9b251e81dcf3b1e74c55fea4fcac63
Bug 944075 - remove attribute parameter from sort(). r=nthomas
(Assignee)

Updated

3 years ago
Attachment #8452801 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

3 years ago
Note: this isn't deployed to production yet. It will probably go there today when I land by patch from bug 1013354.
(Reporter)

Updated

3 years ago
Depends on: 1037440
(Reporter)

Comment 11

3 years ago
This is in production now. Thanks Massimo!
You need to log in before you can comment on or make changes to this bug.