Closed Bug 944075 Opened 9 years ago Closed 8 years ago

/revisions/ page doesn't show who made the most recent change to a rule

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: massimo)

References

Details

Attachments

(2 files, 1 obsolete file)

(Might apply to releases too, I'm not sure if that code is generic.)

Eg: https://aus4-admin.mozilla.org/rules/18/revisions/ shows 5 versions of that rule. I happen to know that Nick made the most recent change, but it doesn't show up in the UI...
Duplicate of this bug: 944083
Bug 944083 also has suggestions for the ordering of the table, and how to display dates of changes.
Assignee: nobody → mgervasini
I don't think this truly blocks moving beta users to balrog, but it is fairly important.
No longer blocks: balrog-beta
Attached patch [balrog] Bug 944075.patch (obsolete) — Splinter Review
Added {{ revision['changed_by'] }} in loop.last
Attachment #8452589 - Flags: review?(bhearsum)
Attachment #8452589 - Flags: review?(bhearsum)
Updated patch so the most recent release is at the top.
Attachment #8452589 - Attachment is obsolete: true
Attachment #8452672 - Flags: review?(nthomas)
Comment on attachment 8452672 [details] [diff] [review]
[balrog] Bug 944075.patch

lgtm
Attachment #8452672 - Flags: review?(nthomas) → review+
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/b9ccdd2a12974a7992f411214dfeed29fdcc78f2
Bug 944075 - /revisions/ page doesn't show who made the most recent change to a rule. r=nthomas
Attachment #8452672 - Flags: checked-in+
Removed attribute='change_id' from sort(). 'attribute' was added in jinja2 and we are using jinjia2 2.5.5
Attachment #8452801 - Flags: review?(nthomas)
Attachment #8452801 - Flags: review?(nthomas) → review+
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/ee9d67842d9b251e81dcf3b1e74c55fea4fcac63
Bug 944075 - remove attribute parameter from sort(). r=nthomas
Attachment #8452801 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Note: this isn't deployed to production yet. It will probably go there today when I land by patch from bug 1013354.
Depends on: 1037440
This is in production now. Thanks Massimo!
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.