944088 - MP4Reader::Init() should assume mLayersBackendType=LAYERS_NONE if it doesn't have a decoder owner

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

[09:42]	yury	cpearce: I'm trying to run fmp4/mse playback locally
[09:42]	yury	getting assert at http://mxr.mozilla.org/mozilla-central/source/content/media/fmp4/MP4Reader.cpp#111
[09:43]	yury	does it need non-virtual window 8.1?
[09:43]	-->|	ekr ([e-mail]) has joined #media
[09:43]	=-=	Mode #media +ao ekr ekr by ChanServ
[09:45]	cpearce	yury: we need that if we're going to get DXVA acceleration. we should do two things:
[09:45]	cpearce	1. provide a decoder owner so that we can get the layer manager so that we can get dxva, and
[09:45]	cpearce	2. not exit with failure if we can't. we can just fallback to software.
[09:46]	|<--	mt has left moznet (Quit: Leaving.)
[09:46]	cpearce	yury: so to get unblocked, just comment out that block.
[09:46]	yury	cool
[09:46]	cpearce	yury: I'll file a bug to address those.


This bug addresses (2) above. If MP4Reader::Init() can't find a decoder owner, we can just assume LAYERS_NONE. This means we won't get hardware accelerated decoding on Windows, but too bad.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Make MP4Reader::Init() assume mLayersBackendType=LAYERS_NONE if it doesn't have a decoder owner. r=kinetik

This ensures that if the MP4Reader fails to get a decoder owner, we
don't abort the media load, but instead we will assume that we don't
have an advanced layers backend, and so fallback to software decoding on
Windows.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

With this patch, we play the "car" MP4 test case at http://dash-mse-test.appspot.com perfectly on Windows. :)

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/499c81cdff30

(In reply to Chris Pearce (:cpearce) from comment #2)
> With this patch, we play the "car" MP4 test case at
> http://dash-mse-test.appspot.com perfectly on Windows. :)

(provided we pref on the demuxer to be exposed of course, we still need to hook it up to MSE)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/499c81cdff30