Closed Bug 944138 Opened 7 years ago Closed 7 years ago

[Australis] Remove secondary hover state from combined panel buttons (e.g. cut/copy/paste)

Categories

(Firefox :: Theme, defect)

28 Branch
x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 29

People

(Reporter: phlsa, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3])

Attachments

(2 files)

Attached image Screen shot
We should reconsider the hover state of the combined buttons in the panel.
Currently, when I move the mouse over one of the items, all three get highlighted. This gets confusing when certain actions are actually disabled (eg. copy when no text is selected).

IMHO we should change the highlight of the group to just a border or leave it out in general. Stephen, any thoughts on that?
Flags: needinfo?(shorlander)
Blocks: australis-cust
No longer blocks: australis-merge
On OS X we definitely don't want hover states on inactive items.

Windows is a little more complicated. Traditional menus do have hover states for inactive elements. However toolbar items and form controls do not. I am inclined to be internally consistent and not have hover states for inactive items, especially since it doesn't really make a lot of sense to have indicators for things you can't interact with.
Flags: needinfo?(shorlander)
Blocks: 878065
Whiteboard: [Australis:P3]
So Stephen, we're OK to remove the "outer" hover state from these buttons?
Flags: needinfo?(shorlander)
I think phlsa is going to talk to shorlander about this in IRL, waiting to hear back from phlsa.
Flags: needinfo?(shorlander) → needinfo?(philipp)
Just talked to shorlander.
So what we should do is to just remove the background from the secondary hover state in general, so that only the outline is left. The direct hover state for the buttons shouldn't change. The behavior should be the same on all OSes.
Flags: needinfo?(philipp)
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
This patch removes setting the background color, but keeps the border on hover.
Attachment #8361585 - Flags: review?(mconley)
Comment on attachment 8361585 [details] [diff] [review]
Patch 1: remove hover background from combined panelbutton

Review of attachment 8361585 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #8361585 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/95ba0745030a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
QA Contact: cornel.ionce
Verified fixed on Firefox 29 beta 1 (build ID: 20140318013849) and on latest Aurora (build ID: 20140320004001).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.