944149 - Optimize nsContentUtils::PositionIsBefore

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: test

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=1ce9c4fbbe0f

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8339650 [details] [diff] [review]
v1

r=me

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8339650 [details] [diff] [review]
v1

Review of attachment 8339650 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsINode.cpp
@@ +741,5 @@
>    }
> +  if (GetPreviousSibling() == &aOtherNode) {
> +    MOZ_ASSERT(GetParentNode() == aOtherNode.GetParentNode());
> +    return static_cast<uint16_t>(nsIDOMNode::DOCUMENT_POSITION_PRECEDING);
> +  } else if (GetNextSibling() == &aOtherNode) {

Drop the else?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: without else

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf413fe5f44e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf413fe5f44e

Comment 8

[Guilherme Lima]

On the test attached here I get
Nightly - 7~10ms
Chrome 31 - 200ms
Firefox Beta - 400ms
IE 11 - 100ms