Closed Bug 944158 Opened 9 years ago Closed 9 years ago

Linkify and improve spidermonkey_build TinderboxPrint messages

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file, 1 obsolete file)

Ugh. The current summary ends up something like


    TinderboxPrint: mozharness_revlink: http: //hg.mozilla.org/build/mozharness/rev/321f2b9bc8cd
    TinderboxPrint: purged clobber
    TinderboxPrint: uploaded to http: //ftp.mozilla.org//pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64-br-haz/20131127145931
    TinderboxPrint: 14/24 hazards, 83 unsafe refs

Notice the space after 'http:'. Something is inserting that; I'm not sure what. The full log does not have it.
But we can do better -- it appears that TinderboxPrint can handle HTML. Probably ought to do the same for the mozharness rev link (which also has the space after http: inserted, I now notice.)
Attachment #8339588 - Flags: review?(aki)
Comment on attachment 8339588 [details] [diff] [review]
Linkify and improve spidermonkey_build TinderboxPrint messages

philor says r-. Tbpl mangles TinderboxPrint lines by parsing out "key:value", which results in the space between the final : in any line. Ugh.
Attachment #8339588 - Flags: review?(aki) → review-
So, I wimped out and added a colon, because it turns out I messed up the buildbot_status() call in a previous patch, and that's preventing the builds from turning red/orange when the hazard count is exceeded.
Attachment #8344079 - Flags: review?(aki)
Attachment #8339588 - Attachment is obsolete: true
Attachment #8344079 - Flags: review?(aki) → review+
Comment on attachment 8344079 [details] [diff] [review]
Linkify and improve spidermonkey_build TinderboxPrint messages

Er, I don't think there's such a thing as TBPL_WARNINGS.
Maybe you mean

from mozharness.mozilla.buildbot import BuildbotMixin, TBPL_WARNING, TBPL_STATUS_DICT

self.buildbot_status(TBPL_STATUS_DICT[TBPL_WARNING]) ?  which is mozharness.base.log.WARNING which is 'warning'.
(In reply to Aki Sasaki [:aki] from comment #4)
> Comment on attachment 8344079 [details] [diff] [review]
> Linkify and improve spidermonkey_build TinderboxPrint messages
> 
> Er, I don't think there's such a thing as TBPL_WARNINGS.
> Maybe you mean
> 
> from mozharness.mozilla.buildbot import BuildbotMixin, TBPL_WARNING,
> TBPL_STATUS_DICT
> 
> self.buildbot_status(TBPL_STATUS_DICT[TBPL_WARNING]) ?  which is
> mozharness.base.log.WARNING which is 'warning'.

Er, maybe I mean self.buildbot_status(TBPL_WARNING) , singular.
And maybe I shouldn't code review while my head's full of lwr part 4.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.