944158 - Linkify and improve spidermonkey_build TinderboxPrint messages

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

Ugh. The current summary ends up something like


    TinderboxPrint: mozharness_revlink: http: //hg.mozilla.org/build/mozharness/rev/321f2b9bc8cd
    TinderboxPrint: purged clobber
    TinderboxPrint: uploaded to http: //ftp.mozilla.org//pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64-br-haz/20131127145931
    TinderboxPrint: 14/24 hazards, 83 unsafe refs

Notice the space after 'http:'. Something is inserting that; I'm not sure what. The full log does not have it.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Linkify and improve spidermonkey_build TinderboxPrint messages

But we can do better -- it appears that TinderboxPrint can handle HTML. Probably ought to do the same for the mozharness rev link (which also has the space after http: inserted, I now notice.)

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8339588 [details] [diff] [review]
Linkify and improve spidermonkey_build TinderboxPrint messages

philor says r-. Tbpl mangles TinderboxPrint lines by parsing out "key:value", which results in the space between the final : in any line. Ugh.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Linkify and improve spidermonkey_build TinderboxPrint messages

So, I wimped out and added a colon, because it turns out I messed up the buildbot_status() call in a previous patch, and that's preventing the builds from turning red/orange when the hazard count is exceeded.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 8344079 [details] [diff] [review]
Linkify and improve spidermonkey_build TinderboxPrint messages

Er, I don't think there's such a thing as TBPL_WARNINGS.
Maybe you mean

from mozharness.mozilla.buildbot import BuildbotMixin, TBPL_WARNING, TBPL_STATUS_DICT

self.buildbot_status(TBPL_STATUS_DICT[TBPL_WARNING]) ?  which is mozharness.base.log.WARNING which is 'warning'.

Comment 5

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #4)
> Comment on attachment 8344079 [details] [diff] [review]
> Linkify and improve spidermonkey_build TinderboxPrint messages
> 
> Er, I don't think there's such a thing as TBPL_WARNINGS.
> Maybe you mean
> 
> from mozharness.mozilla.buildbot import BuildbotMixin, TBPL_WARNING,
> TBPL_STATUS_DICT
> 
> self.buildbot_status(TBPL_STATUS_DICT[TBPL_WARNING]) ?  which is
> mozharness.base.log.WARNING which is 'warning'.

Er, maybe I mean self.buildbot_status(TBPL_WARNING) , singular.
And maybe I shouldn't code review while my head's full of lwr part 4.

Comment 6

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/mozharness/rev/224fc8be64fa

Comment 7

[Steve Fink [:sfink] [:s:]]

Transplanted to production - https://hg.mozilla.org/build/mozharness/rev/ea7c83f7a0ef