Closed Bug 944162 Opened 6 years ago Closed 6 years ago

Add ispixel assertions to AssertionHelper

Categories

(Firefox for Android :: Testing, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: mcomella, Assigned: isurae)

References

Details

(Whiteboard: [mentor=mcomella][lang=java])

Attachments

(1 file, 1 obsolete file)

This should just be a wrapper around Assert.ispixel and Assert.isnotpixel, named in the junit style (e.g. assertIsPixel).

Also, remove the associated TODO in AssertionHelper.
Attached patch 944162.patch (obsolete) — Splinter Review
Attachment #8344221 - Flags: review?(michael.l.comella)
Comment on attachment 8344221 [details] [diff] [review]
944162.patch

lgtm! Thanks for the help!
Attachment #8344221 - Flags: review?(michael.l.comella) → review+
Thanks. My first submission to open source. 

Could you commit this patch for me?
Congratulations! :)

You can add "checkin-needed" to the keywords field to have someone do it for you (so your reviewer doesn't always have to). I'll let you do that now for practice!
Assignee: nobody → isurae
Status: NEW → ASSIGNED
Keywords: checkin-needed
It seems the "String" keyword is lower-cased. Isura, do you mind fixing that?

Make sure you're also compiling the Robocop tests in addition to the Fennec package. You can find the steps at [1]. Please let me know if you have any questions.

[1]: https://wiki.mozilla.org/Auto-tools/Projects/Robocop
Attached patch 944162.patchSplinter Review
I have fixed the type string -> String. 

However I'm not able to compile robocop on ubuntu 13 following the instructions.
I've added android SDK to the path as suggested. 

isura@ubuntu:~/Devel/mozilla-central$ ./mach build build/mobile/robocop
 0:00.33 /usr/bin/make -C /home/isura/Devel/mozilla-central/obj-arm-linux-androideabi -j4 -s backend.RecursiveMakeBackend
 0:00.34 make: /home/isura/opt/adt-bundle-linux/sdk/platforms/android-19/../..//platform-tools/adb: Command not found
 0:00.45 /usr/bin/make -C build/mobile/robocop -j4 -s
 0:00.61 make[1]: /home/isura/opt/adt-bundle-linux/sdk/platforms/android-19/../..//build-tools/17.0.0/aapt: Command not found
 0:00.61 make[1]: *** [.aapt.deps] Error 127
 0:00.61 make: *** [default] Error 2
Attachment #8344221 - Attachment is obsolete: true
Using the android binary, make sure you have the latest "Android SDK Tools", "Android SDK Platform-tools", and "Android SDK Build-tools" packages installed. It seems certain binaries from these packages cannot be found:

>  0:00.34 make: /home/isura/opt/adt-bundle-linux/sdk/platforms/android-19/../..//platform-tools/adb: Command
> not found
>  0:00.45 /usr/bin/make -C build/mobile/robocop -j4 -s
>  0:00.61 make[1]: /home/isura/opt/adt-bundle-linux/sdk/platforms/android-19/../..//build-tools/17.0.0/aapt:
> Command not found

Please let me know if you still have issues or the patch compiles successfully!
I used built-tools version 17 as suggested in the instructions. I then tried with the newest version 19 (so everything is the newest).  The files aapt and adb are located in that location. 

Any ideas? Thanks.
I'm able to build Robocop. The problem was with ia32-lib. From docs

"If you're using a 64-bit Debian or Ubuntu install, you'll need ia32-libs to allow the toolchain binaries to run. Otherwise you may get a "bash: file not found" error when trying to use any of the SDK/NDK tools."

This package is not available on Ubuntu 13 (obsolete). So I used the workaround at http://ubuntuforums.org/showthread.php?t=2182653 (post 4) to install the package.
> I'm able to build Robocop.

Great!

> This package is not available on Ubuntu 13 (obsolete). So I used the workaround at
> http://ubuntuforums.org/showthread.php?t=2182653 (post 4) to install the package.

The Mozilla wiki is actually editable by anyone so do you want to add your workaround to the page? If not, let me know and I can take care of it for you!
Comment on attachment 8345274 [details] [diff] [review]
944162.patch

Review of attachment 8345274 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

(Just a reminder that usually you should add the r? flag when you upload subsequent patch versions for review - I got it this time though)

Don't forget to add the "checkin-needed" keyword!
Attachment #8345274 - Flags: review+
Keywords: checkin-needed
(In reply to Michael Comella (:mcomella) from comment #12)
> > I'm able to build Robocop.
> 
> Great!
> 
> > This package is not available on Ubuntu 13 (obsolete). So I used the workaround at
> > http://ubuntuforums.org/showthread.php?t=2182653 (post 4) to install the package.
> 
> The Mozilla wiki is actually editable by anyone so do you want to add your
> workaround to the page? If not, let me know and I can take care of it for
> you!

I updated the wiki. Thanks for the help.
Keywords: checkin-needed
Keywords: checkin-needed
(In reply to Isura Edirisinghe from comment #14)
> I updated the wiki. Thanks for the help.

Great, thanks!

One last thing is that I would also include the source of the thread you got the workaround from in the Wiki text (though I suppose it is not strictly necessary).
https://hg.mozilla.org/mozilla-central/rev/a3b8fdff3d1e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.