944198 - Assertion failure after removing type attribute from <input type="color">

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: !color.IsEmpty() (Content node's GetValue() should return a valid color string (the default color, in case no valid color is set)), at layout/forms/nsColorControlFrame.cpp:106

Comment 1

[Jesse Ruderman]

Attachment: stack (lldb)

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix+test

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8339749 [details] [diff] [review]
fix+test

>+  // still a color control, which can happen if the type attribute was

s/which can happen/which might not be the case/

r=me

Comment 4

[Arnaud Bienner]

Comment on attachment 8339749 [details] [diff] [review]
fix+test

Review of attachment 8339749 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for me, even if I wasn't asked for a review ;)
Sorry for missing this case when I implemented this :( and thanks for fixing it :)

::: layout/forms/nsColorControlFrame.cpp
@@ +12,5 @@
>  #include "nsGkAtoms.h"
>  #include "nsIDOMHTMLInputElement.h"
>  #include "nsIDOMNode.h"
>  #include "nsStyleSet.h"
> +#include "nsIFormControl.h"

Minor remark: I made this alphabetically ordered and I would prefer to keep ordered.

Comment 5

[Mats Palmgren (inactive)]

Attachment: fix+test, v2 (nits fixed)

Comment 6

[Mats Palmgren (inactive)]

(In reply to Arnaud Bienner from comment #4)
> Sorry for missing this case when I implemented this

No worries, I'm pretty sure I would have made the same mistake if I had
written this handler.  Which makes me wonder if it might be worth the
time to do a brief audit of mutation handlers on other elements for
the same kind of problem...

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4c295c9454

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca4c295c9454