9442 - auto margins in content cause XUL not to display

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

In the two testcases I will attach, the only difference is that the html:p
element in the second has margin-top: auto.

In the Linux build of 1999-07-07 (opt, mozilla.org), this causes the entire
document to be blank.

In the Linux build of 1999-07-01 (opt, mozilla.org), it causes the height of the
paragraph element to expand to 100% (or maybe more).  This happened for auto
margins on any side, and it caused margins on a table to be blank.

I think the two testcases should end up displaying the same way.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: test case without auto margin

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: test case with auto margin

Comment 3

[Peter Trudelle]

reassigning to hyatt as p3 for m9

Comment 4

[David Hyatt]

Delegating to someone else just to balance the bug load.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm seeing similar problems with align="center" on a table, which maps to auto
margins.

What you need to do, is:

* for sizing, treat the auto margins as zero margins
* if, by some miracle, the box is bigger than the table, then use the auto
margins to align the table (or p, or whatever)

I'm also seeing one case where it's only causing misalignment, not complete
disappearance [[ Note to self: main panel of sched. demo, with align="center" on
top and bottom tables ]].  The test cases are complicated, but I could give them
to you if you want [[ Note to self: schedule demo, align="center" everywhere
appropriate.  divActive(2) shows nothing ]]

Comment 6

[Eric Vaughan]

Still have to look a this.

Comment 7

[Eric Vaughan]

The 2 posted examples work. I just assume than automargins are always 0. Tables
should work as well.

Comment 8

[ckritzer (gone)]

Assigning to originator per new organizational structure.

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm reopening this because there's a bug in your fix for the original bug here.
(Is it better to file a separate bug in such a case, or not??)

Currently if *any* of the four margins is auto, then they're all becoming zero.
Making those that are auto zero makes sense, but not making others zero.

I'll attach a pair of test cases that should have a 5em margin on the box on all
but the right side (where the margin should depend on the window size).  The
first has "margin: 5em", and works correctly.  The second has "margin: 5em;
margin-right: auto", and doesn't.

(However, I think auto side margins on an element with a given width in a
vertically aligned box that is given a fixed width should be properly computed.
Perhaps I'll file another RFE bug on that.  This would make <table
align="center"> work (if tables work OK otherwise).)

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: test case that correctly shows 5em margin

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: test case that does not show 5em margin, but should

Comment 12

[Eric Vaughan]

I understand that it would be nice to have auto margin in xul but
unfortunately all those calculation are done in the html reflow system. It would
be a great deal of work so make this happen and would greatly complexify boxes.
Its a good idea but is definitely not something that will happen before beta. So
I'm going to close this bug as fixed because xul does display. If you feel
strongly about this can you please post another bug that is a feature request
that xul boxes should support auto margins.

Thanks

Comment 13

[ckritzer (gone)]

Changing QA Contact back to [e-mail].

Dave, any thoughts on evaughn's comments?  I'll close this bug out by next
Monday if I hear no feedback.

Thanks!

Comment 14

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.

Comment 15

[ckritzer (gone)]

Massive QA Contact update.