944234 - [Fugu] [B2G] The cardState of second sim card is always 'unknown'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Attachment: logcat.txt

Put two sim card into fugu device, the cardState of second sim card is always 'unknown'.

Comment 1

[Edgar Chen [:edgar]]

Quick checking the log:

*First sim:
11-28 11:47:20.150   106   106 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"cardstatechange","cardState":"ready"}
11-28 11:47:24.520   106   106 I Gecko   : -*- RILContentHelper: Received message 'RIL:CardStateChanged': {"clientId":0,"data":{"rilMessageType":"cardstatechange","cardState":"ready"}}

*Second sim:
11-28 11:47:19.990   106   106 I Gecko   : -*- RadioInterface[1]: Received message from worker: {"rilMessageType":"cardstatechange","cardState":"pukRequired"}
// But the RILContentHelper did not get the RIL:CardStateChange IPC message for second sim card.

Comment 2

[Edgar Chen [:edgar]]

=====
// got the cardState change for both two sim
11-28 11:47:19.990   106   106 I Gecko   : -*- RadioInterface[1]: Received message from worker: {"rilMessageType":"cardstatechange","cardState":"pukRequired"}
11-28 11:47:20.150   106   106 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"cardstatechange","cardState":"ready"}

// got system-message-listener-read event
11-28 11:47:23.920   106   106 I GeckoDump: XXX FIXME : Got a mozContentEvent: system-message-listener-ready
====

Gecko got the cardState change for both two sim before system-message-listener is ready. In this case, |gMessageManager| will queue these events first and resent it after got system-message-listener-ready. But if the there two events with same message name, |gMessageManager| will only keep the new one and drop the old one [1].

So in this case the cardStateChange of second sim is dropped by |gMessageManager|. 

[1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js?from=RadioInterfaceLayer.js#305

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v1

We need to take clinet id into account, same message type with different client id should be treated as a different message.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8340178 [details] [diff] [review]
Patch, v1

Review of attachment 8340178 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 5

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=86324548eb8f

Comment 6

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7763ec5989d2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7763ec5989d2

Comment 8

[Jason Smith [:jsmith]]

Seems like this is a blocker for multi-SIM support.