944265 - Do proper quoting of DEFINES

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

What broke ASAN when bug 874266 landed is that ac_configure_args contains many things, and one of them is "--enable-optimize='something with spaces'". When that goes through the quoting in data.py, that fails because we're just adding quotes around the string, and that's clearly not enough.

Relatedly, the treatment done to ACDEFINES is better, but using double quotes causes problems with pristine non-msys GNU make paired with msys bash on windows (which is a setup i want to get working because it would avoid a lot of shell invocations).

Comment 1

[Mike Hommey [:glandium]]

Attachment: Do proper quoting of DEFINES, and do the same for ACDEFINES

Note: I don't feel like doing it now, but we're not doing this quoting at the right level, because it's specific to how make invokes command lines and other backends may not want to do the same kind of quoting, but we're currently imposing it upon them.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8339769 [details] [diff] [review]
Do proper quoting of DEFINES, and do the same for ACDEFINES

Review of attachment 8339769 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding test coverage.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9af1bfc53b44

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9af1bfc53b44