Closed Bug 944265 Opened 8 years ago Closed 8 years ago

Do proper quoting of DEFINES

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

What broke ASAN when bug 874266 landed is that ac_configure_args contains many things, and one of them is "--enable-optimize='something with spaces'". When that goes through the quoting in data.py, that fails because we're just adding quotes around the string, and that's clearly not enough.

Relatedly, the treatment done to ACDEFINES is better, but using double quotes causes problems with pristine non-msys GNU make paired with msys bash on windows (which is a setup i want to get working because it would avoid a lot of shell invocations).
Note: I don't feel like doing it now, but we're not doing this quoting at the right level, because it's specific to how make invokes command lines and other backends may not want to do the same kind of quoting, but we're currently imposing it upon them.
Attachment #8339769 - Flags: review?(gps)
Comment on attachment 8339769 [details] [diff] [review]
Do proper quoting of DEFINES, and do the same for ACDEFINES

Review of attachment 8339769 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding test coverage.
Attachment #8339769 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/9af1bfc53b44
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Depends on: 944551
Blocks: 944634
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.