944274 - The self.lockscreen.is_locked is True when user unlock from lockscreen to camera with passcode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

After have the discussion with Tim, the self.lockscreen.is_locked is True when user unlock from lockscreen to camera with passcode.
Becasue this camera is system's camera, and the lockscreen still be locked.

gaiatest/gaia_test.py:
    @property
    def is_locked(self):
        self.marionette.switch_to_frame()
        return self.marionette.execute_script('return window.wrappedJSObject.LockScreen.locked')

gaiatest/tests/functional/lockscreen/test_lockscreen_unlock_to_camera_with_passcode.py:
        camera = self.lock_screen.unlock_to_camera()
        self.lock_screen.wait_for_lockscreen_not_visible()
        self.assertFalse(self.lockscreen.is_locked)

Comment 1

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 14164

Comment 2

[Zac C (:zac)]

https://github.com/mozilla-b2g/gaia/commit/d0191b283c926d10179b186ead9f5eb1e62b80b1

Comment 3

[Bob Silverberg [:bsilverberg]]

Askeing, please take a look at bug 944692, which proposes a different solution. Which makes the most sense?

Comment 4

[Askeing Yen[:askeing][:fyen]]

Hmm, I think it is a trade off. 
We can keep the assertion to make sure the value should be True after unlock to camera with passcode.
Or we can remove the assertion to only focus on UI.

If we only want to focus on UI, I will suggest to remove it.

Comment 5

[Zac C (:zac)]

I agree with Tim that it is still locked. 

After Alive merges his AppWindowManager pull I plan to try to change this to focus on the UI (camera frame) being the active one so a short term fix here is fine.

This came around because the is_locked property never actually worked but Dave fixed it the other day.

Comment 7

[Florin Strugariu [:Bebe]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14407

Pointer to Github pull-request

Comment 8

[[:AndreiH]]

Landed in v1.2
https://github.com/mozilla-b2g/gaia/commit/3d022fc687804fcf1e65b4b740886f2d11a41149