Closed Bug 944438 Opened 9 years ago Closed 9 years ago

Get rid of InstallSignalHandlersMutex

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: iacobcatalin, Assigned: iacobcatalin)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=819839#c28

Luke Wagner says:

"
Initially EnsureAsmJSSignalHandlers was called lazily, so you could race if two workers happened to compile asm.js at the same time.  Now it is called in JSRuntime::init, which I think we can assume happens-before other JSRuntime create.  Thus, I'd be fine if you replaced all that junk with a simple

  static bool sHandlersInstalled = false;

which was tested/set where lock.handlersInstalled()/lock.setHandlersInstalled() are called now.
"
Assignee: nobody → iacobcatalin
Attachment #8340035 - Flags: review?(luke)
Comment on attachment 8340035 [details] [diff] [review]
get-rid-of-InstallSignalHandlersMutex.patch

Thanks!
Attachment #8340035 - Flags: review?(luke) → review+
Keywords: checkin-needed
Blocks: 819839
Depends on: 945077
https://hg.mozilla.org/mozilla-central/rev/bc2e4db71486
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.