944438 - Get rid of InstallSignalHandlersMutex

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Catalin Iacob]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=819839#c28

Luke Wagner says:

"
Initially EnsureAsmJSSignalHandlers was called lazily, so you could race if two workers happened to compile asm.js at the same time.  Now it is called in JSRuntime::init, which I think we can assume happens-before other JSRuntime create.  Thus, I'd be fine if you replaced all that junk with a simple

  static bool sHandlersInstalled = false;

which was tested/set where lock.handlersInstalled()/lock.setHandlersInstalled() are called now.
"

Comment 1

[Catalin Iacob]

Attachment: get-rid-of-InstallSignalHandlersMutex.patch

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8340035 [details] [diff] [review]
get-rid-of-InstallSignalHandlersMutex.patch

Thanks!

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2e4db71486

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bc2e4db71486