DeCOMify imgIContainer::GetFrame

RESOLVED FIXED in mozilla29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In the process of converting imgIContainer::GetFrame to Moz2D it seems like we should DeCOMify it too. None of the callers except nsLayoutUtils::SurfaceFromElement check the nsresult return value, and nsLayoutUtils::SurfaceFromElement only checks if it failed and returns a default object in that case.
(Assignee)

Comment 1

5 years ago
Created attachment 8345553 [details] [diff] [review]
patch

One of the groundwork patches I wrote preparing the ground to converte imgIContainer::GetFrame to return a Moz2D SourceSurface instead of a Thebes gfxASurface. Might as well get this out of my tree before it rots.
Attachment #8345553 - Flags: review?(roc)
Comment on attachment 8345553 [details] [diff] [review]
patch

Review of attachment 8345553 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not an imglib peer
Attachment #8345553 - Flags: review?(roc) → review?(seth)
Comment on attachment 8345553 [details] [diff] [review]
patch

Review of attachment 8345553 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The less COM the better, I say.
Attachment #8345553 - Flags: review?(seth) → review+
(Assignee)

Comment 5

5 years ago
I missed a spot in widget/windows/WinUtils.cpp which I fixed in the original checkin, but forgot to change the error code check to a null check. Fixed in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5c5a325b15
https://hg.mozilla.org/mozilla-central/rev/826415ddd250
https://hg.mozilla.org/mozilla-central/rev/bd5c5a325b15
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

5 years ago
Blocks: 950360
(Assignee)

Updated

5 years ago
Blocks: 950372

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.