Closed
Bug 944442
Opened 10 years ago
Closed 10 years ago
DeCOMify imgIContainer::GetFrame
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
34.41 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
In the process of converting imgIContainer::GetFrame to Moz2D it seems like we should DeCOMify it too. None of the callers except nsLayoutUtils::SurfaceFromElement check the nsresult return value, and nsLayoutUtils::SurfaceFromElement only checks if it failed and returns a default object in that case.
Assignee | ||
Comment 1•10 years ago
|
||
One of the groundwork patches I wrote preparing the ground to converte imgIContainer::GetFrame to return a Moz2D SourceSurface instead of a Thebes gfxASurface. Might as well get this out of my tree before it rots.
Attachment #8345553 -
Flags: review?(roc)
Comment on attachment 8345553 [details] [diff] [review] patch Review of attachment 8345553 [details] [diff] [review]: ----------------------------------------------------------------- I'm not an imglib peer
Attachment #8345553 -
Flags: review?(roc) → review?(seth)
Comment 3•10 years ago
|
||
Comment on attachment 8345553 [details] [diff] [review] patch Review of attachment 8345553 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. The less COM the better, I say.
Attachment #8345553 -
Flags: review?(seth) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/826415ddd250
Assignee | ||
Comment 5•10 years ago
|
||
I missed a spot in widget/windows/WinUtils.cpp which I fixed in the original checkin, but forgot to change the error code check to a null check. Fixed in: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5c5a325b15
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/826415ddd250 https://hg.mozilla.org/mozilla-central/rev/bd5c5a325b15
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•