944442 - DeCOMify imgIContainer::GetFrame

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Jonathan Watt [:jwatt]]

In the process of converting imgIContainer::GetFrame to Moz2D it seems like we should DeCOMify it too. None of the callers except nsLayoutUtils::SurfaceFromElement check the nsresult return value, and nsLayoutUtils::SurfaceFromElement only checks if it failed and returns a default object in that case.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

One of the groundwork patches I wrote preparing the ground to converte imgIContainer::GetFrame to return a Moz2D SourceSurface instead of a Thebes gfxASurface. Might as well get this out of my tree before it rots.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8345553 [details] [diff] [review]
patch

Review of attachment 8345553 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not an imglib peer

Comment 3

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8345553 [details] [diff] [review]
patch

Review of attachment 8345553 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The less COM the better, I say.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/826415ddd250

Comment 5

[Jonathan Watt [:jwatt]]

I missed a spot in widget/windows/WinUtils.cpp which I fixed in the original checkin, but forgot to change the error code check to a null check. Fixed in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5c5a325b15

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/826415ddd250
https://hg.mozilla.org/mozilla-central/rev/bd5c5a325b15