Closed Bug 944444 Opened 10 years ago Closed 10 years ago

Fix js/ compilation on mingw.

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28
Tracking Flags:
Tracking Status
firefox28 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch.diff
6.69 KB, patch
Waldo
: review+
Details | Diff | Splinter Review
Attached patch patch.diff — — Splinter Review 
This patch contains both followup of bug 928351 and additional fixes that were pending in my tree:

- pid_t is declared on mingw, so protect it by _MSC_VER instead of XP_WIN
- _CRT_RAND_S is defined too late for mingw. I moved it to makefile.
- Casts to jschar* are no loner needed (they were not needed for a while, now some of them may cause problems).
- Use wchar_t* instead of PRUnichar* in Windows API.
Attachment #8340019 - Flags: review?(jwalden+bmo)
Attachment #8340019 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/70d4fcbcd68a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.