Closed
Bug 944444
Opened 11 years ago
Closed 11 years ago
Fix js/ compilation on mingw.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
6.69 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
This patch contains both followup of bug 928351 and additional fixes that were pending in my tree:
- pid_t is declared on mingw, so protect it by _MSC_VER instead of XP_WIN
- _CRT_RAND_S is defined too late for mingw. I moved it to makefile.
- Casts to jschar* are no loner needed (they were not needed for a while, now some of them may cause problems).
- Use wchar_t* instead of PRUnichar* in Windows API.
Attachment #8340019 -
Flags: review?(jwalden+bmo)
|
||
Updated•11 years ago
|
Attachment #8340019 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28:
--- → fixed
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•