944495 - [Single Variant] Race condition when installing single variant apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Carmen Jimenez Cabezas]

STR: 

1. Install a v1.2 build on device
2. Clone the tests repository for sigle variant: https://github.com/telefonicaid/firefoxos-gaia-testsbuild.git
3. Configure the file variant.json to add the mcc and mnc of the SIM card you are going to use
4. Clone Gaia repository and select the v1.2 branch.
5. Execute the command "GAIA_DISTRIBUTION_DIR=URL/firefoxos-gaia-testsbuild  PRODUCTION=1 make reset-gaia" to install gaia with single variant on the device
6. Complete FTE  with the configured SIM (configured in the json file)

Expected: 

The apps are installed correctly and they are placed in the correct (configured) screen and position

Actual: 
Sometimes some applications are installed on the first free spot

The problem is that there is a race condition. Sometimes gecko starts installing some of the single variant apps before the homescreen has finished reading its configuration file. When that happens the onInstall handler is executed before the single variant apps are configured and thus single variant apps are treated as normal apps. 
The apps whose installation start after the homescreen has finished reading its configuration file are treated correctly (i.e. they are recognized as single variant apps).

Comment 1

[Carmen Jimenez Cabezas]

There is a WIP possible solution at: 

https://github.com/mcjimenez/gaia/commit/04084bd1e2902447f8b366e12fc2d17ac022a07d

This WIP solve the problem, the only thing remaining is to clean it a little and of course write a master version. Oh, and finish updating the tests.

Can you take a look to see if I should finish it this way, Cristian?

Comment 2

[Cristian Rodriguez (:crdlc)]

Please follow my advice offline, thanks a lot for you good work

Comment 3

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v1 according to the offline discussion

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8340774 [details] [review]
Proposed patch v1 according to the offline discussion

Please address the comments and ask again for a review, thanks a lot

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8340774 [details] [review]
Proposed patch v1 according to the offline discussion

More comments, thanks

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8340774 [details] [review]
Proposed patch v1 according to the offline discussion

Great job! Thanks a lot

Comment 7

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/573304f58bb431c3622a86786b5e17aaa65b07b9

Comment 8

[Preeti Raghunath(:Preeti)]

koi+ IOT from TEF and other partners.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 573304f58bb431c3622a86786b5e17aaa65b07b9
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 10

[Carmen Jimenez Cabezas]

Rebased and merged:
https://github.com/mozilla-b2g/gaia/commit/198db92ffb4aae13d047fb92276d282789a4828a

Comment 11

[rafael.marquez]

Verified:

Device: unagi
Branch: v1.2
Gecko: 18c6a00
Gaia: f615ae7