944559 - [Session Restore] Just say no to sessionstore.js spam

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Here's another idea: add (pref-controlled) limits after which we simply decide that we should not store anything meaningful about a site.

e.g.
- if DOM storage + postdata + formdata exceeds 1Mb; or
- if the tab has more than 100 frames;
- etc.

In this case, just give up about that tab and store only a set of URLs.

Comment 1

[Florian Bender]

Maybe also a LRU policy for (sub-)ressources? So if this exceeds a threshold (maybe 10), drop the oldest data (not containing forms) etc.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: First draft

Let's start with a simple patch that should act as countermeasure for bug 934935 (now solved by the webdevs), bug 942601.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8340323 [details] [diff] [review]
First draft

Review of attachment 8340323 [details] [diff] [review]:
-----------------------------------------------------------------

It seems like this would be better covered by broadcasting scroll and form data separately. With that we're just able to discard session history for any dynamic frames.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

David, now that we only store DOMSessionStorage and form data for the tab's current history entry, and discard dynamic frames, do we still need this bug? I'd be inclined to close it.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Ok, let's close it. We'll reopen it if necessary.