944560 - ToC rendering in new theme is hard to read

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

What did you do?
================
The way in which the new theme provides a nexted table of contents block looks pretty bad, for example:

https://developer.mozilla.org/en-US/User:wbamberg/Add-ons/SDK/High-Level_APIs/tabs#isPinned_.3A_boolean

The way the bullets are rendered us much worse than the indented tree style of indentation used previously, or in the Add-on SDK docs.

What happened?
==============
The ToC structure is rendered as if it is the table of contents in a reference book

What should have happened?
==========================
The tablje of contents should preserve the established indented / nested look from both the previous MDN theme *and* the SDK docs which are the source for the material in the page I linked to.

Is there anything else we should know?
======================================

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: toc in the new theme - hard to read

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: toc rendered with the original MDN theme

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: toc rendered in the Add-on SDK docs

Comment 4

[Luke Crouch [:groovecoder]]

There are a few bugs discussing this, but I don't remember which ones they are. Holly can you link them here?

David - how much work is it to run an A/B test w/ optimizely to give the ToC an indented tree style?

Comment 5

[Holly Habstritt Gaal [:Habber]]

TOC related bugs I have been cc'd on:

TOC should indent subheadings
https://bugzilla.mozilla.org/show_bug.cgi?id=914797

TOC doesn't work when <h3> without <h2>
https://bugzilla.mozilla.org/show_bug.cgi?id=916444

The fact the TOC is collapsable is hardly discoverable
https://bugzilla.mozilla.org/show_bug.cgi?id=916042

Comment 6

[David Walsh :davidwalsh]

Not long to A/B test but if it's something that's been complained about forever we should just pick a solution to run with.  It sounds like the current style set upsets people.

Comment 7

[Luke Crouch [:groovecoder]]

Making a call based on discussion in mdn-drivers [1]:

Take out the numbers (this bug), restore the indentation (bug 914797). We can do them both in a single commit, and see if that also fixes bug 916444.

[1] https://groups.google.com/d/msg/mozilla.mdn.drivers/uaACdzCJKgg/yLlNTUCwDuIJ

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/9189ba2e8d196d027fb253ab191f556239626b9c
fix bug 947832, 944560, 937136, 914797, 914946 - Remove TOC counters and indent listing

https://github.com/mozilla/kuma/commit/ccfa5791f9471046c541dad989d456b276d99f1a
Merge pull request #1783 from darkwing/toc-spacing

fix bug 947832, 944560, 937136, 914797, 914946 - Remove TOC counters and indent listing