944567 - [Flatfish ]: Camera recording should support AAC encoding based on Android JB (4.2.2)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Vincent Liu[:vliu]]

This bug is filed according to the bug 932204 Comment 13.

https://bugzilla.mozilla.org/show_bug.cgi?id=932204#c13

Comment 1

[Vincent Liu[:vliu]]

Attachment: bug-944567-fix-v1.patch

This is the patch to enable AAC recording based on Android JB(4.2.2). Can you help me to review it? Thanks.

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8340186 [details] [diff] [review]
bug-944567-fix-v1.patch

Review of attachment 8340186 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
This code is need to get reviewed by mikeh. Add mikeh review?.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8340186 [details] [diff] [review]
bug-944567-fix-v1.patch

Review of attachment 8340186 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, but what exactly does it do? Just enable AAC recording on Flatfish? (Without affecting the use of AMRNB on other devices?)

Comment 4

[Vincent Liu[:vliu]]

This patch added switch-case selection for OUTPUT_FORMAT_AAC_XXX and kept the use of AMRNB. I believe it won't affect for AMRNB case.

http://mxr.mozilla.org/mozilla-central/source/dom/camera/GonkRecorder.cpp#662

Comment 5

[Vincent Liu[:vliu]]

Try server result

https://tbpl.mozilla.org/?tree=Try&rev=e09a111ad4ce
https://tbpl.mozilla.org/?tree=Try&rev=2a5b220c4d25

This bug should uplift to 1.3 because bug 932204 marked as 1.3.

Comment 6

[Vincent Liu[:vliu]]

This is a common problem for ANDROID_VERSION >= 17. Besides master branch, this patch also need to uplift to 1.3.

Comment 7

[Francis Lee [:frlee]]

as the patch is ready and base on comment 6, we need this for JB. change it to 1.3+ as triage result

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/98bb25549bc9

Vincent, can you please change your name in hg from vliu to your full name? Thanks :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98bb25549bc9

Comment 10

[Vincent Liu[:vliu]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #8)
> https://hg.mozilla.org/integration/b2g-inbound/rev/98bb25549bc9
> 
> Vincent, can you please change your name in hg from vliu to your full name?
> Thanks :)

Thanks for kindly remind. I'd fixed it in .hgrc. :)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6c2182c002a9