944575 - When exporting a local contact to SIM save the iccContactId in order to align with bug 943234

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

We need to store the iccContactId provided in a local contact (not previously imported from the SIM) - export flow in order to reuse it and not to duplicate the contact if it is exported two times.

Comment 1

[Jose Manuel Cantera]

Attachment: 14198.html

for testing it is needed the corresponding Gecko patch

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8340199 [details]
14198.html

Looking good to me,

r+,

is there any chance to add a couple of extra unit test for the new methods?

Thanks!

Comment 3

[Jose Manuel Cantera]

landed in master, including the tests requested by Francisco

https://github.com/mozilla-b2g/gaia/commit/a9468b0ad5923badb7130a60b639914d9b227985

Comment 4

[Jose Manuel Cantera]

for the same reasons as bug 943234 this should be also koi+

Comment 5

[Preeti Raghunath(:Preeti)]

koi+ for broken feature similar to 943234.https://bugzilla.mozilla.org/show_bug.cgi?id=943234

Comment 6

[Jose Manuel Cantera]

Attachment: 14412.html

patch for v1.2

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8343075 [details]
14412.html

Looking good to me, tested on the phone and working fine.

Please merge once travis is green :)

Thanks Jose!

Comment 8

[Jose Manuel Cantera]

landed in v1.2

https://github.com/mozilla-b2g/gaia/commit/2bf37840ce35f3317a93eef47264a0ca83ab7edf

Comment 9

[isabelrios]

Verified with 12/16 v1.2 build:
Gecko-f6f325b
Gaia-fcf1c2f

If the same contact manually created in the contact list is exported twice to the SIM Card, it is not duplicated in the SIM Card.

Comment 10

[Noemí Freire (:noemi)]

removing status-b2g-v1.3 flag since the patch was landed before v1.3 branch creation (https://bugzilla.mozilla.org/show_bug.cgi?id=944575#c3)