Closed Bug 944575 Opened 6 years ago Closed 6 years ago

When exporting a local contact to SIM save the iccContactId in order to align with bug 943234

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

VERIFIED FIXED
1.2 C6(Dec6)
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: jmcf, Assigned: jmcf)

References

Details

Attachments

(2 files)

We need to store the iccContactId provided in a local contact (not previously imported from the SIM) - export flow in order to reuse it and not to duplicate the contact if it is exported two times.
Attached file 14198.html
for testing it is needed the corresponding Gecko patch
Attachment #8340199 - Flags: review?(francisco.jordano)
Comment on attachment 8340199 [details]
14198.html

Looking good to me,

r+,

is there any chance to add a couple of extra unit test for the new methods?

Thanks!
Attachment #8340199 - Flags: review?(francisco.jordano) → review+
Blocks: 922988
landed in master, including the tests requested by Francisco

https://github.com/mozilla-b2g/gaia/commit/a9468b0ad5923badb7130a60b639914d9b227985
for the same reasons as bug 943234 this should be also koi+
blocking-b2g: --- → koi?
koi+ for broken feature similar to 943234.https://bugzilla.mozilla.org/show_bug.cgi?id=943234
blocking-b2g: koi? → koi+
Attached file 14412.html
patch for v1.2
Attachment #8343075 - Flags: review?(francisco.jordano)
Comment on attachment 8343075 [details]
14412.html

Looking good to me, tested on the phone and working fine.

Please merge once travis is green :)

Thanks Jose!
Attachment #8343075 - Flags: review?(francisco.jordano) → review+
landed in v1.2

https://github.com/mozilla-b2g/gaia/commit/2bf37840ce35f3317a93eef47264a0ca83ab7edf
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Keywords: verifyme
Target Milestone: --- → 1.2 C6(Dec6)
Verified with 12/16 v1.2 build:
Gecko-f6f325b
Gaia-fcf1c2f

If the same contact manually created in the contact list is exported twice to the SIM Card, it is not duplicated in the SIM Card.
Status: RESOLVED → VERIFIED
Keywords: verifyme
removing status-b2g-v1.3 flag since the patch was landed before v1.3 branch creation (https://bugzilla.mozilla.org/show_bug.cgi?id=944575#c3)
You need to log in before you can comment on or make changes to this bug.