944613 - [Settings] The 'SIM manager' should be 'SIM Manager'

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Other entries are all follows the pattern:

   Foo Bar

So this should be fixed. I think this should be a good first bug, but maybe it's too obvious.

Comment 1

[Giovanny Gongora [:gioyik]]

Hi,

could you say me where is located this line to be fixed to make a pull request with the fix?

Regards,
Gio

Comment 2

[[e-mail]]

Hi, thanks for concerning fix it. Please open settings app's code and search the string.

Generally there are 2 places need to be change, 
* one is from settings/index.html, 
* another is the locales/settings.en-US.properties

the other locales will be translated by l10n groups

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Since it's far from the last comment, Wayne has done his patch and pushed the Pull Request. So I would take this bug for him.

Comment 4

[Tzu-Wen Lin [:waynux]]

Attachment: Patch

Use "grep" to search and fix 2 places: settings/index.html and locales/settings.en-US.properties

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8362383 [details] [review]
Patch

Thanks for contributing, Wayne! But I'm afraid that this is not a valid bug. SIM manager follows the new title wording policy. Please refer to bug 936398 for details. You can also steal it if you want.