944679 - Do not return nullptr in DeprecatedTextureHostBasic::GetAsSurface

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andreas Pehrson [:pehrsons]]

To follow up on the comments in bug 907292. It was changed to return nullptr in bug 942318."

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Do not return nullptr in DeprecatedTextureHostBasic::GetAsSurface.

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8340342 [details] [diff] [review]
Do not return nullptr in DeprecatedTextureHostBasic::GetAsSurface.

This should fix the nullptr in DeprecatedTextureHostBasic.

David, adding you here since you wrote the latest patch for GetAsSurface where the nullptr was put in.

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8340342 [details] [diff] [review]
Do not return nullptr in DeprecatedTextureHostBasic::GetAsSurface.

Review of attachment 8340342 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the review lag, I've been a bit busy lately.
So, I looked at why the return nullptr was put here in the first place (rather than returning a gfxImageSurface as it was doing before), and apparently this was done in the process of Moz2Difying the TextureHost.
Before that, it used to return mThebesSurface, but as mThebesSurface was replaced by its Moz2D counterpart, GetAsSurface simply got it's implem removed.
All I wanted to check was that this was not an intentional fix for a bug of the previous implementation, so it's good.

Comment 4

[Andreas Pehrson [:pehrsons]]

Cool, so what's the standard procedure for getting the patch in? It is the responsibility of the assignee to get everything through I gather? And in my case that would be by setting the checkin-needed flag?

What's the policy on running tests before check-in? Do you routinely push things to try? Would a bad patch get caught on inbound in the worst case?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7c22bdbf800

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a7c22bdbf800